Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identity V3: public facing changes #252

Merged
merged 6 commits into from
Jul 15, 2021
Merged

identity V3: public facing changes #252

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1d08a7f
added deprecation notices
aboedo Jan 27, 2021
4ee349e
removed internal modifiers to make logIn and logOut public
aboedo Jan 27, 2021
7ea0ad3
updated ReplaceWith declarations
aboedo Feb 19, 2021
e5c3c51
fixed missing closing bracket in replaceWith
aboedo Feb 19, 2021
73feee3
made logInWith and logOutWith public
aboedo Mar 2, 2021
145819a
removed @Jvmsynthetic since they're not needed anymore for logIn and …
aboedo Jul 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
added deprecation notices
  • Loading branch information
@aboedo
aboedo committed Jul 14, 2021
commit 1d08a7fa2e480a49bc5bc1fe3c18f03e188ec3f7
13 changes: 13 additions & 0 deletions purchases/src/main/kotlin/com/revenuecat/purchases/Purchases.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,11 @@ class Purchases @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE) intern
* default. If true treats all purchases as restores, aliasing together appUserIDs that share a
* Play Store account.
*/

@Deprecated(
"Replaced with configuration in the RevenueCat dashboard",
ReplaceWith("configure through the RevenueCat dashboard")
)
var allowSharingPlayStoreAccount: Boolean
@Synchronized get() =
state.allowSharingPlayStoreAccount ?: identityManager.currentUserIsAnonymous()
Expand Down Expand Up @@ -700,6 +705,10 @@ class Purchases @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE) intern
* @param newAppUserID The new appUserID that should be linked to the currently user
* @param [listener] An optional listener to listen for successes or errors.
*/
@Deprecated(
"Use logIn instead",
ReplaceWith("logIn")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add the parameters of the logIn function that way the developers get a nice automatic "replace with" option in Android Studio. Maybe it works just specifying the function name, but I don't think so...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, didn't know that was a thing, will do!

)
@JvmOverloads
fun identify(
newAppUserID: String,
Expand Down Expand Up @@ -781,6 +790,10 @@ class Purchases @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE) intern
* id and save it in the cache.
* @param [listener] An optional listener to listen for successes or errors.
*/
@Deprecated(
"Use logOut instead",
ReplaceWith("logOut")
)
@JvmOverloads
fun reset(
listener: ReceivePurchaserInfoListener? = null
Expand Down