Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: identity v3 bugs #260

Merged
merged 5 commits into from
Mar 4, 2021
Merged

Fix: identity v3 bugs #260

merged 5 commits into from
Mar 4, 2021

Conversation

aboedo
Copy link
Member

@aboedo aboedo commented Mar 2, 2021

Fixes a couple of bugs with identity v3:

  • logInWith wasn't internal, but it's not meant to be public yet
  • the endpoint url was updated from login to identify
  • added logOutWith method

@aboedo aboedo requested a review from vegaro March 2, 2021 19:55
@aboedo aboedo self-assigned this Mar 2, 2021
fun Purchases.logInWith(
internal fun Purchases.logInWith(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

although this is in develop, it has luckily not made it into a release yet, so we should be good.

@aboedo aboedo mentioned this pull request Mar 2, 2021
3 tasks
@aboedo aboedo force-pushed the fix/identify_endpoint_path branch from c512dc2 to 7f3d26a Compare March 3, 2021 14:00
@aboedo aboedo requested a review from vegaro March 3, 2021 14:09
@aboedo aboedo force-pushed the fix/identify_endpoint_path branch from 878a0d7 to 0037287 Compare March 4, 2021 14:01
@aboedo aboedo merged commit 1527eb0 into develop Mar 4, 2021
@aboedo aboedo deleted the fix/identify_endpoint_path branch March 4, 2021 14:13
@aboedo aboedo mentioned this pull request May 27, 2021
@aboedo aboedo mentioned this pull request Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants