Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent error message if clowdenvironment does not exist, pre-push, requeue true #186

Merged
merged 17 commits into from
Oct 9, 2023
+111 −47
Merged

Silent error message if clowdenvironment does not exist, pre-push, requeue true #186

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c22337d
return error if clowdenv exists but has error
maknop Sep 21, 2023
4ac08c9
Updating log messages
maknop Sep 27, 2023
a8739d2
pre push
maknop Sep 27, 2023
dbbca44
updated errors
maknop Oct 2, 2023
c1a6bbc
removing mutex locks
maknop Oct 2, 2023
a1cc56d
Fixed linting issue
maknop Oct 2, 2023
34636c3
Fixing err issue
maknop Oct 2, 2023
9fb80e8
return nil on status update
maknop Oct 3, 2023
932a42c
requeue on failure, return nil
maknop Oct 3, 2023
9eca462
fix return value
maknop Oct 5, 2023
8b8bb1d
return err instead of nil
maknop Oct 5, 2023
38f6cc1
revert this back to main
maknop Oct 6, 2023
27d4361
update logic for retrieving reservation object
maknop Oct 6, 2023
c52828d
return nil if not found
maknop Oct 6, 2023
b1bbb9c
fix log output
maknop Oct 6, 2023
69cc1dc
Reverting file change
maknop Oct 9, 2023
554d713
Merge branch 'main' into mknop/cleanup-log-errors
maknop Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
pre push
  • Loading branch information
@maknop
maknop committed Oct 9, 2023
commit a8739d29c962361fef7f5c3376ab053f0904e074
129 changes: 96 additions & 33 deletions deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ objects:
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.8.0
controller-gen.kubebuilder.io/version: v0.11.1
creationTimestamp: null
name: namespacepools.cloud.redhat.com
spec:
Expand Down Expand Up @@ -83,6 +83,13 @@ objects:
description: Defines the Configuration for the Clowder Database
Provider.
properties:
caBundleURL:
description: Indicates where Clowder will fetch the
database CA certificate bundle from. Currently only
used in (*_app-interface_*) mode. If none is specified,
the AWS RDS combined CA bundle is used.
pattern: ^https?:\/\/.+$
type: string
mode:
description: 'The mode of operation of the Clowder Database
Provider. Valid options are: (*_app-interface_*) where
Expand Down Expand Up @@ -197,6 +204,9 @@ objects:
Kafka cluster is deleted Only applies when KafkaConfig.PVC
is set to 'true'
type: boolean
forceTLS:
description: Force TLS
type: boolean
jvmOptions:
description: JVM Options
properties:
Expand Down Expand Up @@ -322,25 +332,6 @@ objects:
description: EnableLegacyStrimzi disables TLS + user
auth
type: boolean
ephemManagedDeletePrefix:
description: Defines a prefix whitelist value
type: string
ephemManagedSecretRef:
description: Defines the secret reference for the Ephemeral
Managed Kafka mode. Only used in (*_managed-ephem_*)
mode.
properties:
name:
description: Name defines the Name of a resource.
type: string
namespace:
description: Namespace defines the Namespace of
a resource.
type: string
required:
- name
- namespace
type: object
managedPrefix:
description: Managed topic prefix for the managed cluster.
Only used in (*_managed_*) mode.
Expand Down Expand Up @@ -552,6 +543,30 @@ objects:
the default resource requirements from the ClowdEnvironment
will be used.
properties:
claims:
description: "Claims lists the names of resources,\
\ defined in spec.resourceClaims, that are\
\ used by this container. \n This is an alpha\
\ field and requires enabling the DynamicResourceAllocation\
\ feature gate. \n This field is immutable."
items:
description: ResourceClaim references one
entry in PodSpec.ResourceClaims.
properties:
name:
description: Name must match the name
of one entry in pod.spec.resourceClaims
of the Pod where this field is used.
It makes that resource available inside
a container.
type: string
required:
- name
type: object
type: array
x-kubernetes-list-map-keys:
- name
x-kubernetes-list-type: map
limits:
additionalProperties:
anyOf:
Expand Down Expand Up @@ -597,6 +612,31 @@ objects:
description: Defines the resource requests/limits
set on selenium containers
properties:
claims:
description: "Claims lists the names\
\ of resources, defined in spec.resourceClaims,\
\ that are used by this container.\
\ \n This is an alpha field and requires\
\ enabling the DynamicResourceAllocation\
\ feature gate. \n This field is immutable."
items:
description: ResourceClaim references
one entry in PodSpec.ResourceClaims.
properties:
name:
description: Name must match the
name of one entry in pod.spec.resourceClaims
of the Pod where this field
is used. It makes that resource
available inside a container.
type: string
required:
- name
type: object
type: array
x-kubernetes-list-map-keys:
- name
x-kubernetes-list-type: map
limits:
additionalProperties:
anyOf:
Expand Down Expand Up @@ -727,6 +767,18 @@ objects:
a ClowdApp should be served on.
format: int32
type: integer
tls:
description: TLS sidecar enablement
properties:
enabled:
type: boolean
port:
format: int32
type: integer
privatePort:
format: int32
type: integer
type: object
required:
- mode
- port
Expand All @@ -742,6 +794,28 @@ objects:
k8s format in the event that they omitted from a PodSpec inside
a ClowdApp.
properties:
claims:
description: "Claims lists the names of resources, defined\
\ in spec.resourceClaims, that are used by this container.\
\ \n This is an alpha field and requires enabling the\
\ DynamicResourceAllocation feature gate. \n This field\
\ is immutable."
items:
description: ResourceClaim references one entry in PodSpec.ResourceClaims.
properties:
name:
description: Name must match the name of one entry
in pod.spec.resourceClaims of the Pod where this
field is used. It makes that resource available
inside a container.
type: string
required:
- name
type: object
type: array
x-kubernetes-list-map-keys:
- name
x-kubernetes-list-type: map
limits:
additionalProperties:
anyOf:
Expand Down Expand Up @@ -1011,6 +1085,7 @@ objects:
type: object
type: array
type: object
x-kubernetes-map-type: atomic
scopes:
description: A collection of filters that must match
each object tracked by a quota. If not specified,
Expand Down Expand Up @@ -1134,17 +1209,11 @@ objects:
storage: true
subresources:
status: {}
status:
acceptedNames:
kind: ''
plural: ''
conditions: []
storedVersions: []
- apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.8.0
controller-gen.kubebuilder.io/version: v0.11.1
creationTimestamp: null
name: namespacereservations.cloud.redhat.com
spec:
Expand Down Expand Up @@ -1239,12 +1308,6 @@ objects:
storage: true
subresources:
status: {}
status:
acceptedNames:
kind: ''
plural: ''
conditions: []
storedVersions: []
- apiVersion: v1
kind: ServiceAccount
metadata:
Expand Down