Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent error message if clowdenvironment does not exist, pre-push, requeue true #186

Merged
merged 17 commits into from
Oct 9, 2023
+111 −47
Merged

Silent error message if clowdenvironment does not exist, pre-push, requeue true #186

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c22337d
return error if clowdenv exists but has error
maknop Sep 21, 2023
4ac08c9
Updating log messages
maknop Sep 27, 2023
a8739d2
pre push
maknop Sep 27, 2023
dbbca44
updated errors
maknop Oct 2, 2023
c1a6bbc
removing mutex locks
maknop Oct 2, 2023
a1cc56d
Fixed linting issue
maknop Oct 2, 2023
34636c3
Fixing err issue
maknop Oct 2, 2023
9fb80e8
return nil on status update
maknop Oct 3, 2023
932a42c
requeue on failure, return nil
maknop Oct 3, 2023
9eca462
fix return value
maknop Oct 5, 2023
8b8bb1d
return err instead of nil
maknop Oct 5, 2023
38f6cc1
revert this back to main
maknop Oct 6, 2023
27d4361
update logic for retrieving reservation object
maknop Oct 6, 2023
c52828d
return nil if not found
maknop Oct 6, 2023
b1bbb9c
fix log output
maknop Oct 6, 2023
69cc1dc
Reverting file change
maknop Oct 9, 2023
554d713
Merge branch 'main' into mknop/cleanup-log-errors
maknop Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update logic for retrieving reservation object
  • Loading branch information
@maknop
maknop committed Oct 9, 2023
commit 27d436122b7f4c8a15d127e1a0fbcd265b9e9c9a
5 changes: 3 additions & 2 deletions controllers/cloud.redhat.com/namespacereservation_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,9 @@ func (r *NamespaceReservationReconciler) Reconcile(ctx context.Context, req ctrl
// Must have been deleted
return ctrl.Result{}, nil
}
r.log.Error(err, fmt.Sprintf("Reservation not found for namespace [%s]", req.NamespacedName.Namespace))
return ctrl.Result{}, err

r.log.Error(err, fmt.Sprintf("there was an issue retrieving the reservation object for namespace [%s]", req.NamespacedName.Namespace))
return ctrl.Result{Requeue: true}, err
}

if res.Status.Pool == "" {
Expand Down