Silent error message if clowdenvironment does not exist, pre-push, requeue true #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psav
requested changes
Oct 3, 2023
psav
requested changes
Oct 4, 2023
controllers/cloud.redhat.com/namespacereservation_controller.go
Outdated
Show resolved
Hide resolved
maknop
changed the title
psav
previously requested changes
Oct 6, 2023
controllers/cloud.redhat.com/namespacereservation_controller.go
Outdated
Show resolved
Hide resolved
maknop
force-pushed
the
mknop/cleanup-log-errors
branch
from
8085258 to
b1bbb9c
Compare
|
/retest |
1 similar comment
|
/retest |
adamrdrew
approved these changes
Oct 9, 2023
maknop
dismissed
psav’s stale review
I don't see what it's hung up on and Adam looked it all over. I already handled the changes reqested so I'm going to have this dismissed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are error messages in the logs that state that a clowdenvironement does not exist. This is occurring during a time when the corresponding namespace is already gone. When this namespace is removed, the clowdenvironment is also cleaned up.
Also did a pre-push and added some
requeue: true.