Skip to content

Pulls from MakeCode fork the ability to rename and delete variables i…#2144

Merged
alschmiedt merged 1 commit intoRaspberryPiFoundation:developfrom
alschmiedt:delete_variable_menuItem
Nov 30, 2018
Merged

Pulls from MakeCode fork the ability to rename and delete variables i…#2144
alschmiedt merged 1 commit intoRaspberryPiFoundation:developfrom
alschmiedt:delete_variable_menuItem

Conversation

@alschmiedt
Copy link
Contributor

…n flyout

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

#1105

Proposed Changes

Adds ability to rename and delete a variable through the context menu in the variable flyout. Discussed here: #2143
screen shot 2018-11-29 at 2 29 02 pm
.

Reason for Changes

So that users can delete or rename a variable without first having to drag it into the workspace.

Test Coverage

Tested on:

Additional Information

This code is pulled from the MakeCode fork found here: microsoft/pxt-blockly@2537e07

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

Copy link
Contributor

@RoboErikG RoboErikG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alschmiedt alschmiedt merged commit 670e432 into RaspberryPiFoundation:develop Nov 30, 2018
@alschmiedt alschmiedt deleted the delete_variable_menuItem branch November 30, 2018 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants