Merged
Conversation
Fixes #2096 We were creating a text node to wrap any block connected to next when we should have just been attaching the generated dom.
Update version number
…_checkbox Select generator test suites by checkbox
…n_browser Run generator tests on Travis
Bad commit during debugging.
#172, Fixed [Edge, IE] Zoom control mouseover is not clipped
Fixes #1653 Makes the bounds checker created in inject correctly set the event group before moving blocks in bounds. When a workspace can't scroll the inject method sets up an event listener to bump blocks back into the visible bounds when dropped off the edge. The event group wasn't being used, though, causing the move to be a separate undo step. When undone, this would get you stuck in a loop where the workspace would keep pulling it back into the visible range.
Reconnects child blocks when an undo is done on an else block
Groups events fired during field input change
Disable insertion markers for the December 2018 release
Update dependencies
Rebuild uncompressed and language files
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
Fixes #1958 This will drop the input when it's in the empty string state. This causes the block to remove the input and re-add it when the text is reverted, but prevents the breakage. A followup fix should leave the input alone instead of removing it, but this works for now.
Avoid crashing when a procedure input has an empty string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues closed
Pull requests