Feature/ibms #586

dalebremner · 2017-02-09T23:22:41Z

Merge master to feature branch

Conflicts: lib/jobs/install-os.js Merge branch 'master' of https://github.com/RackHD/on-http Conflicts: data/templates/esx-ks accepted origin/master code Conflicts: data/templates/centos-ks Merge branch 'master' of https://github.com/RackHD/on-taskgraph Conflicts: lib/graphs/install-esx-graph.js accepted origin/master code

… interfaces is passed. Updated Esx-ks to dowload callback script in %post and run in %firstboot

add swagger python-client deb build back

add the identifier property to the node schema

Fix task annotation

that json encoding escapes on and renders incorrectly. This removes those characters and allows correct encoding. Signed-off-by: Ethan Kaley <ethan.kaley@emc.com>

Fixed typos Further explained the issue and need for fix

Cisco Version Header string contains extra escape characters

…esx-kickstart-update Conflicts: data/templates/esx-ks

Ztip esx kickstart update

- Set bmc credentials used to get user count of enabled bmc users It should get the toal nb of bmc users - Remove users fails the user list command; Added logic to get the open channel nb - Migrate set bms credentials from discovery graph to Discovery-sku-graph in discovery graph, group label is set in bootstrap and it overides the tasks properties

'Allowing for systems with more than 26 drives'

* There is problem with PATCH method schema which require url attribute. Also there are typos and style problems. * Separate schemas are created for POST/PATCH method to solve schema problem. Typos are also fixed.

Bugfix for set bmc credentials

prevent render error if networkDevices is not defined

Update Redfish schemas to 2016.3

Revert "Ztip esx kickstart update"

Hook API design

Add Deprecation Warning Header to 1.1 northbound/southbound router

Conflicts: static/monorail-2.0.yaml static/schemas/2.0/node.2.0.json

houndci-bot · 2017-02-09T23:23:00Z

spec/lib/services/schema-api-service-spec.js


        var path = helper.injector.get('path');
-        return validator.addNamespace(path.resolve(__dirname, '../../../static/DSP8010_1.0.0/json-schema'),
+        return validator.addNamespace(path.resolve(__dirname, '../../../static/DSP8010_2016.3/json-schema'),


Line is too long.

houndci-bot · 2017-02-09T23:23:00Z

lib/services/hooks-api-service.js

+    _,
+    Errors
+) {
+    var logger = Logger.initialize(hookApiServiceFactory);


'logger' is defined but never used.

JenkinsRHD · 2017-02-09T23:50:52Z

BUILD on-http #3232 : FAILURE

** BUILD build-config-setup #1537: SUCCESS
** BUILD unit-tests #11582: UNSTABLE
** BUILD Install-Ubuntu-14-04 #133: FAILURE
** BUILD SmokeTest-FIT #169: FAILURE
** BUILD SmokeTest-CIT #364: FAILURE
** BUILD Install-CentOs-6.5 #155: FAILURE

BUILD unit-tests #11582 Error Logs ▼

Test Name: 2.0 Http.Api.Nodes GET /nodes/:identifier/ssh should return a list of the node's ssh settings Error Details: Cannot read property 'findAllByNode' of undefined Stack Trace: TypeError: Cannot read property 'findAllByNode' of undefined at Context.<anonymous> (spec/lib/api/2.0/nodes-spec.js:383:27)

Test Name: 2.0 Http.Api.Nodes GET /nodes/:identifier/ssh should return a 404 if the node has no ssh settings
Error Details: Cannot read property 'findAllByNode' of undefined
Stack Trace: TypeError: Cannot read property 'findAllByNode' of undefined
at Context.<anonymous> (spec/lib/api/2.0/nodes-spec.js:400:27)

Test Name: 2.0 Http.Api.Nodes POST /nodes/:identifier/ssh should replace existing settings with a new set of ssh settings
Error Details: Cannot read property 'upsertByNode' of undefined
Stack Trace: TypeError: Cannot read property 'upsertByNode' of undefined
at Context.<anonymous> (spec/lib/api/2.0/nodes-spec.js:436:27)

Test Name: 2.0 Http.Api.Nodes POST /nodes/:identifier/ssh should add a new set of ssh settings if none exist
Error Details: Cannot read property 'upsertByNode' of undefined
Stack Trace: TypeError: Cannot read property 'upsertByNode' of undefined
at Context.<anonymous> (spec/lib/api/2.0/nodes-spec.js:449:27)

Test Name: Http.Api.Ibms /api/2.0/ibms should return a list of IBM instances
Error Details: Should wrap property of object
Stack Trace: TypeError: Should wrap property of object
at Object.wrapMethod (node_modules/sinon/lib/sinon/util/core.js:67:23)
at Object.stub (node_modules/sinon/lib/sinon/stub.js:61:26)
at Context.<anonymous> (spec/lib/api/2.0/ibms-spec.js:106:26)

Test Name: Http.Api.Ibms /api/2.0/ibms should put an IBM instance
Error Details: Should wrap property of object
Stack Trace: TypeError: Should wrap property of object
at Object.wrapMethod (node_modules/sinon/lib/sinon/util/core.js:67:23)
at Object.stub (node_modules/sinon/lib/sinon/stub.js:61:26)
at Context.<anonymous> (spec/lib/api/2.0/ibms-spec.js:121:26)

Test Name: Http.Api.Ibms /api/2.0/ibms should 400 when put with unloaded schema
Error Details: Should wrap property of object
Stack Trace: TypeError: Should wrap property of object
at Object.wrapMethod (node_modules/sinon/lib/sinon/util/core.js:67:23)
at Object.stub (node_modules/sinon/lib/sinon/stub.js:61:26)
at Context.<anonymous> (spec/lib/api/2.0/ibms-spec.js:133:26)

Test Name: Http.Api.Ibms /api/2.0/ibms should 400 when put with missing field
Error Details: Should wrap property of object
Stack Trace: TypeError: Should wrap property of object
at Object.wrapMethod (node_modules/sinon/lib/sinon/util/core.js:67:23)
at Object.stub (node_modules/sinon/lib/sinon/stub.js:61:26)
at Context.<anonymous> (spec/lib/api/2.0/ibms-spec.js:145:26)

Test Name: Http.Api.Ibms /api/2.0/ibms/:id "before each" hook for "should get an IBM instance"
Error Details: Should wrap property of object
Stack Trace: TypeError: Should wrap property of object
at Object.wrapMethod (node_modules/sinon/lib/sinon/util/core.js:67:23)
at Object.stub (node_modules/sinon/lib/sinon/stub.js:61:26)
at Context.<anonymous> (spec/lib/api/2.0/ibms-spec.js:160:19)

Test Name: Http.Api.Ibms /api/2.0/ibms/:id "after each" hook for "should get an IBM instance"
Error Details: Cannot read property 'needByIdentifier' of undefined
Stack Trace: TypeError: Cannot read property 'needByIdentifier' of undefined
at Context.<anonymous> (spec/lib/api/2.0/ibms-spec.js:166:27)

yyscamper · 2017-02-10T10:22:14Z

@dalebremner : please rebase your branch, as I see a lot code shouldn't belong to your PR.

brianparry · 2017-02-10T16:01:59Z

@yyscamper This PR is just to merge master into the feature branch to resolve conflicts. It's not even really intended for review. The code shown is here is code in master that wasn't previously in the feature branch which is appropriate for what we're doing. Since the feature branch is public, it is unsafe to rebase because of the effect it could have on downstream developers (see: https://git-scm.com/docs/git-rebase#_recovering_from_upstream_rebase). The real PR for review is the one up against master #570

nucklehead and others added 30 commits June 16, 2016 14:05

added post lookups + dhcp to latest esx-ks

9a18606

shutdown day

e8160b3

merged with master

cc0513e

merged with rackhd master and fixed centos-ks

0318667

fixed cnetos-ks

506bfbd

pulled master branch again

fc17519

ztip demo hardwarepool 4

b237333

Updated centos-ks to set interfaces to dhcp by default when a list of…

f802d33

… interfaces is passed. Updated Esx-ks to dowload callback script in %post and run in %firstboot

carved branch for esx-ks changes

de92023

removed swagger folder

ba14751

Hook API design

a7d1fea

add swagger python-client deb build back

f7b75d7

Merge pull request #563 from panpan0000/StopTravisCI

4fa77e7

add swagger python-client deb build back

add the identifier property to the node schema

8bd5a0e

fix task annotation link

c36098d

show link after npm run taskdoc

4352052

Merge pull request #567 from tannoa2/ucsRackmount

3440f10

add the identifier property to the node schema

Merge pull request #569 from yyscamper/fix-task-annotation

c41d02d

Fix task annotation

Cisco Version Header string contains characters

1433256

that json encoding escapes on and renders incorrectly. This removes those characters and allows correct encoding. Signed-off-by: Ethan Kaley <ethan.kaley@emc.com>

Additional Details to Clarify Proposed Changes

cfdc41e

Fixed typos Further explained the issue and need for fix

Merge pull request #573 from project-voyager/master

d8a3153

Cisco Version Header string contains extra escape characters

jump version for new release 1.1.0

b75e591

Merge branch 'master' of https://github.com/RackHD/on-http into ztip-…

32e9dc5

…esx-kickstart-update Conflicts: data/templates/esx-ks

Merge pull request #497 from nucklehead/ztip-esx-kickstart-update

212a96d

Ztip esx kickstart update

'Allowing for systems with more than 26 drives'

d1c3be0

Update Redfish schemas to 2016.3

bc7da45

expanding regex for hd[a-z][a-z] as well

d58dd54

shortening regex

026b674

geoff-reid and others added 12 commits February 6, 2017 12:58

prevent render error if networkDevices is not defined

535676f

Merge pull request #577 from ytjohn/fixdrivelines

3f1f225

'Allowing for systems with more than 26 drives'

Update review comments on hook API

fa28305

* There is problem with PATCH method schema which require url attribute. Also there are typos and style problems. * Separate schemas are created for POST/PATCH method to solve schema problem. Typos are also fixed.

Revert "Ztip esx kickstart update"

30320cb

Merge pull request #578 from keedya/master

4d7b080

Bugfix for set bmc credentials

Merge pull request #582 from geoff-reid/windows_install_fix

82e99c9

prevent render error if networkDevices is not defined

Merge pull request #579 from dalebremner/redfish2016

d392304

Update Redfish schemas to 2016.3

Merge pull request #583 from RackHD/revert-497-ztip-esx-kickstart-update

6f38f6f

Revert "Ztip esx kickstart update"

Add Deprecation Warning Header to 1.1 northbound/southbound router

52c388b

Merge pull request #554 from pengz1/Hook-design-for-Progress

90857cf

Hook API design

Merge pull request #585 from srinia6/master

8419476

Add Deprecation Warning Header to 1.1 northbound/southbound router

Merge remote-tracking branch 'origin/master' into feature/ibms

92a4e80

Conflicts: static/monorail-2.0.yaml static/schemas/2.0/node.2.0.json

houndci-bot reviewed Feb 9, 2017

View reviewed changes

BillyAbildgaard approved these changes Feb 10, 2017

View reviewed changes

brianparry merged commit 8f1073c into RackHD:feature/ibms Feb 10, 2017

JenkinsRHD mentioned this pull request Sep 25, 2017

Replace the profiles and templates api implementations with grpc call into on-taskgraph #787

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/ibms #586

Feature/ibms #586

Uh oh!

dalebremner commented Feb 9, 2017 •

edited

Loading

Uh oh!

houndci-bot Feb 9, 2017

Uh oh!

houndci-bot Feb 9, 2017

Uh oh!

JenkinsRHD commented Feb 9, 2017

Uh oh!

yyscamper commented Feb 10, 2017

Uh oh!

brianparry commented Feb 10, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

Feature/ibms #586

Feature/ibms #586

Uh oh!

Conversation

dalebremner commented Feb 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

houndci-bot Feb 9, 2017

Choose a reason for hiding this comment

Uh oh!

houndci-bot Feb 9, 2017

Choose a reason for hiding this comment

Uh oh!

JenkinsRHD commented Feb 9, 2017

Uh oh!

yyscamper commented Feb 10, 2017

Uh oh!

brianparry commented Feb 10, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

dalebremner commented Feb 9, 2017 •

edited

Loading