Skip to content

Update Redfish schemas to 2016.3 #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brianparry merged 1 commit into from
Feb 7, 2017
Merged

Update Redfish schemas to 2016.3 #579

brianparry merged 1 commit into from
Feb 7, 2017

Conversation

@dalebremner
Copy link
Contributor

@dalebremner dalebremner commented Feb 3, 2017 •
edited by brianparry
Loading

houndci-bot
houndci-bot reviewed Feb 3, 2017
View reviewed changes
spec/lib/services/schema-api-service-spec.js

var path = helper.injector.get('path');
return validator.addNamespace(path.resolve(__dirname, '../../../static/DSP8010_1.0.0/json-schema'),
return validator.addNamespace(path.resolve(__dirname, '../../../static/DSP8010_2016.3/json-schema'),
Copy link

@houndci-bot houndci-bot Feb 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long.

@dalebremner dalebremner mentioned this pull request Feb 3, 2017
Merged
@jimturnquist
Copy link
Contributor

jimturnquist commented Feb 3, 2017

@dalebremner Is the CIT failure noted above fixed with the following:

RackHD/RackHD#610

@dalebremner
Copy link
Contributor Author

dalebremner commented Feb 3, 2017

jenkins: test this please

@jimturnquist
Copy link
Contributor

jimturnquist commented Feb 3, 2017

@dalebremner Just confirming...

The changes in static/DSP8010_1.0.0 were taken wholesale from spmf, correct?

I'm focusing my review on the following:

/data/views/redfish-1.0/redfish.1.0.0.computersystem.1.0.0.json
a/data/views/redfish-1.0/redfish.1.0.0.jsonschemafile.1.0.0.json
a/data/views/redfish-1.0/redfish.1.0.0.processor.1.0.0.json
a/data/views/redfish-1.0/redfish.1.0.0.role.1.0.0.json
a/data/views/redfish-1.0/redfish.1.0.0.thermal.1.0.0.json
a/lib/api/redfish-1.0/account-service.js
a/lib/api/redfish-1.0/chassis.js
a/lib/api/redfish-1.0/event-service.js
a/lib/api/redfish-1.0/managers.js
a/lib/api/redfish-1.0/registry.js
a/lib/api/redfish-1.0/roles.js
a/lib/api/redfish-1.0/schemas.js
a/lib/api/redfish-1.0/service-root.js
a/lib/api/redfish-1.0/session-service.js
a/lib/api/redfish-1.0/systems.js
a/lib/api/redfish-1.0/task-service.js
a/lib/services/redfish-validator-service.js
a/spec/lib/api/redfish-1.0/event-service-spec.js
a/spec/lib/api/redfish-1.0/schemas-spec.js
a/spec/lib/services/schema-api-service-spec.js

@dalebremner
Copy link
Contributor Author

dalebremner commented Feb 3, 2017

jenkins: test this please

@dalebremner
Copy link
Contributor Author

dalebremner commented Feb 3, 2017

@jimturnquist Correct. The /static changes are unmodified schemas from DMTF

@dalebremner
Copy link
Contributor Author

dalebremner commented Feb 6, 2017

Jenkins: test this please

@changev
Copy link
Member

changev commented Feb 7, 2017

test this please

@JenkinsRHD
Copy link
Contributor

JenkinsRHD commented Feb 7, 2017

BUILD on-multi #59 : FAILURE

jimturnquist
jimturnquist approved these changes Feb 7, 2017
View reviewed changes
Copy link
Contributor

@jimturnquist jimturnquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with these changes as they are.

@brianparry
Copy link
Contributor

brianparry commented Feb 7, 2017

test this please

brianparry
brianparry approved these changes Feb 7, 2017
View reviewed changes
Copy link
Contributor

@brianparry brianparry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brianparry brianparry merged commit d392304 into RackHD:master Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@jimturnquist jimturnquist jimturnquist approved these changes

@brianparry brianparry brianparry approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dalebremner @jimturnquist @changev @JenkinsRHD @brianparry @houndci-bot