Cisco Version Header string contains extra escape characters #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that json encoding escapes on and renders incorrectly. This removes those characters and allows correct encoding. Signed-off-by: Ethan Kaley <ethan.kaley@emc.com>
Contributor
Author
Contributor
|
👍 was tested against a Cisco switch |
keedya
approved these changes
Jan 26, 2017
|
looks good. Thanks @nucklehead |
king-jam
changed the title
Fixed typos Further explained the issue and need for fix
king-jam
approved these changes
Jan 27, 2017
Contributor
king-jam
left a comment
king-jam
left a comment
There was a problem hiding this comment.
Added some comments to clarify but changes are good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that json encoding escapes on and renders incorrectly.
This removes those characters and allows correct encoding.
Signed-off-by: Ethan Kaley ethan.kaley@emc.com