Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[drivers][crypto]add device CRC/RNG #2844

Merged
merged 8 commits into from
Jul 19, 2019

Conversation

ErnestChen1
Copy link

@ErnestChen1 ErnestChen1 commented Jul 10, 2019

拉取/合并请求描述:(PR description)

[
新增 stm32 硬件CRC与 RNG 驱动,及其配置。

在stm32f091,F103,F407,F767, H743, l475 与l496上面测试通过

]

以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other style
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 本拉取/合并请求代码是高质量的 Code in this PR is of high quality

Copy link
Contributor

@rtthread-bot rtthread-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoTest Result

Rate: 86.96%
Passed: 20/23

点击查看详情

Copy link
Contributor

@rtthread-bot rtthread-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoTest Result

Rate: 82.61%
Passed: 19/23

点击查看详情

@BernardXiong BernardXiong added the in progress PR/issue in progress. label Jul 11, 2019
@ErnestChen1 ErnestChen1 force-pushed the drv_crypto branch 3 times, most recently from 55bdf73 to d485b3a Compare July 11, 2019 06:56
Copy link
Contributor

@rtthread-bot rtthread-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoTest Result

Rate: 86.96%
Passed: 20/23

点击查看详情

Copy link
Contributor

@rtthread-bot rtthread-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoTest Result

Rate: 86.96%
Passed: 20/23

点击查看详情

Copy link
Contributor

@rtthread-bot rtthread-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoTest Result

Rate: 78.26%
Passed: 18/23

点击查看详情

Copy link
Contributor

@rtthread-bot rtthread-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoTest Result

Rate: 86.96%
Passed: 20/23

点击查看详情

Copy link
Contributor

@rtthread-bot rtthread-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoTest Result

Rate: 86.96%
Passed: 20/23

点击查看详情

@ErnestChen1 ErnestChen1 force-pushed the drv_crypto branch 2 times, most recently from 37456d7 to 189b2a2 Compare July 11, 2019 10:31
Copy link
Contributor

@rtthread-bot rtthread-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoTest Result

Rate: 86.96%
Passed: 20/23

点击查看详情

Copy link
Contributor

@rtthread-bot rtthread-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoTest Result

Rate: 86.96%
Passed: 20/23

点击查看详情

Copy link
Contributor

@rtthread-bot rtthread-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoTest Result

Rate: 82.61%
Passed: 19/23

点击查看详情

Copy link
Contributor

@rtthread-bot rtthread-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoTest Result

Rate: 82.61%
Passed: 19/23

点击查看详情

@armink
Copy link
Member

armink commented Jul 12, 2019

@BernardXiong 我这里没问题了

Copy link
Contributor

@rtthread-bot rtthread-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoTest Result

Rate: 86.96%
Passed: 20/23

点击查看详情

@ErnestChen1 ErnestChen1 force-pushed the drv_crypto branch 2 times, most recently from fdcff15 to b82f9db Compare July 12, 2019 10:48
Copy link
Contributor

@rtthread-bot rtthread-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoTest Result

Rate: 86.96%
Passed: 20/23

点击查看详情

@BernardXiong
Copy link
Member

是感觉source "../libraries/HAL_Drivers/Kconfig.crypto" 加了很多,改动的文件也很多,这部分是否可以简化些?

Copy link
Contributor

@rtthread-bot rtthread-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoTest Result

Rate: 86.96%
Passed: 20/23

点击查看详情

@ErnestChen1
Copy link
Author

ErnestChen1 commented Jul 15, 2019

是感觉source "../libraries/HAL_Drivers/Kconfig.crypto" 加了很多,改动的文件也很多,这部分是否可以简化些?

定位为片上外设,每个bsp 都需要,就连同 template一起添加了

@BernardXiong
Copy link
Member

是感觉source "../libraries/HAL_Drivers/Kconfig.crypto" 加了很多,改动的文件也很多,这部分是否可以简化些?

定位为片上外设,每个bsp 都需要,就连同 template一起添加了

所以也可以直接添加到这个Kconfig文件中?

stm32/libraries/Kconfig

@ErnestChen1
Copy link
Author

是感觉source "../libraries/HAL_Drivers/Kconfig.crypto" 加了很多,改动的文件也很多,这部分是否可以简化些?

定位为片上外设,每个bsp 都需要,就连同 template一起添加了

所以也可以直接添加到这个Kconfig文件中?

stm32/libraries/Kconfig

效果图发微信了,可以查看一下

Copy link
Contributor

@rtthread-bot rtthread-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoTest Result

Rate: 86.96%
Passed: 20/23

点击查看详情

@ErnestChen1
Copy link
Author

ErnestChen1 commented Jul 18, 2019

改名字之后,dist 工程与 env 配置测试正常

Copy link
Contributor

@rtthread-bot rtthread-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoTest Result

Rate: 82.61%
Passed: 19/23

点击查看详情

Copy link
Contributor

@rtthread-bot rtthread-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoTest Result

Rate: 86.96%
Passed: 20/23

点击查看详情

Copy link
Contributor

@rtthread-bot rtthread-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoTest Result

Rate: 86.96%
Passed: 20/23

点击查看详情

tools/mkdist.py Outdated
@@ -125,7 +125,7 @@ def bsp_update_kconfig(dist_dir):

def bsp_update_kconfig_library(dist_dir):
# change RTT_ROOT in Kconfig
if not os.path.isfile(os.path.join(dist_dir, 'Kconfig')):
if not os.path.isfile(os.path.join(dist_dir, 'Kconfig')) or not os.path.isfile(os.path.join(dist_dir, 'board/Kconfig')):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要修改为两行,分别判断是否需要执行相应的函数。

Copy link
Contributor

@rtthread-bot rtthread-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoTest Result

Rate: 78.26%
Passed: 18/23

点击查看详情

Copy link
Contributor

@rtthread-bot rtthread-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoTest Result

Rate: 86.96%
Passed: 20/23

点击查看详情

@BernardXiong
Copy link
Member

/stm32/stm32_xx_bsp/Kconfig

不需要修改吗?里面也有:

source "../libraries/Kconfig"

@BernardXiong BernardXiong merged commit c352c2b into RT-Thread:master Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress PR/issue in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants