rsx: Fixups and improvements #5565

kd-11 · 2019-01-16T17:36:55Z

Rewrite index buffer base offsets. Preserves use of u16 index buffers for consistency and reduced memory footprint.
Partial revert of a change in fbo_fixes PR affecting async shaders.
Fix Red-Blue color inversion when using OpenGL (old regression)
Avoid potential deadlock in fifoctrl
Reimplement alpha-to-coverage transparency with a better approximation technique
Rewrite vertex attribute divisor logic
Misc spec compliance and typo fixes

uaqlover · 2019-01-16T19:37:53Z

where i can download the branch

digitaldude555 · 2019-01-16T19:41:25Z

Click green checkmark and click details.

stride21 · 2019-01-16T22:35:35Z

Can confirm that The Last of Us, Battlefield: Bad Company and Uncharted 3 no longer have issues with Async Shader Compiler.

Before:

After:

legend800 · 2019-01-17T03:59:53Z

Tested a bunch of games and didn't see any improvements or regressions.

This regression from FBO fixes PR is still active:
#4949

Tested all of these titles (disregard the general emu notes - not related to PR - but maybe of some interest):
• *(d)Time Crisis 4 Settings: WCB | Note: Input lag sometimes (broken)
• *(d)Deadstorm Pirates(+install data) Settings: WCB | Note: Minor transparent textures (logged)
• Backbreaker Vengeance(v1.0-c00)[WCB(field cache), Blit(fixes textures on VK)] 22 fps on 5-2 (need 25 min) | Settings: Scaling 100%, SPU=2 | Note: Missing crowd (Vk broken-logged, SPU LLVM broken-logged)
• (d)Captain America(3D)[Stretch, Strict (Cap shading)] – Slow(~20 fps on curr. lvl)
• (d)Conan – missing textures (logged) (hangs during loads 50%-logged)
• (d)GOW3[Accurate Getllar?} ~20 fps, minor gfx issues, little unstable
• (d)MotorStorm(2-revenge,devil)[WCB] – gfx issues
• NFL Blitz(v1.0) – Exploding vertices(logged)| Settings: SPU=2
• Ridge Racer 7(3D)(25-special events) – Tree flickering (logged)
• (d)Splatterhouse(1-surv.)(eur)PPU mem crashes (PPU Inter. for areas like start of chapters-but 15 fps - logged)
• Wipeout HD(1-Fury)(v2.51)[WCB for bloom] Little slow (~25 at start on 1st lvl, usually 60 after 1st laps, 40 on lows)
• Force Unleashed 2 – Hangs on load
• Split Second [WCB (fixes bg)] – ~8 fps, Bad gfx
• Double Dragon Neon – Broken gfx (background-logged)

stride21 · 2019-01-17T19:25:23Z

In this PR the mini map flickers various colors when near objectives but when close to enemies it starts flickering stars of various colors and sizes all over the screen. With no enemies or objectives near by on the mini map everything seems the same as master.

PR:

Master:

PR:

Master:

rpcs3 log.zip

MarioSonic2987 · 2019-01-18T13:34:48Z

Improves foliage rendering in Red Dead Redemption.

Before:

After:

stride21 · 2019-01-18T22:17:13Z

Infamous 2 regression is now fixed with the recent commit.

Master:

PR:

stride21 · 2019-01-19T00:25:55Z

Battlefield: Bad Company and Ratchet and Clank Future: Tools of Destruction have exploding vertices in this PR. Bad Company has it when destroying walls and Tools of Destruction has it multiple places like when enemies attack or explode and while grinding on the rails.

Master:

PR:

RPCS3.log.gz

legend800 · 2019-01-19T06:30:50Z

Whoa, did some perf testing with the latest build and I gained close to +3 fps across several games. Nice work!

I think you may have fixed those horizontal line artifacts on GOW3/Ascension effects too. Someone else will need to confirm as I can't get past the first area due to low fps + timing on QTE.

legend800 · 2019-01-19T07:15:05Z

Wow, you just made NFL Blitz FULLY playable by fixing this:
#5132

Wipeout HD has those exploding vertices/lines regression:

MarioSonic2987 · 2019-01-19T07:41:09Z

Fixes some missing models in this place and trees shadows are rendered for the first time (as square shadows).

Before:

After:

Here's a better screenshot that shows clearly these improvements.

legend800 · 2019-01-19T07:46:38Z

Jesus, this is getting ridiculous now. You fixed the background of Double Dragon Neon finally. This PR is unreal.

#5517

PR:

Master:

MSuih · 2019-01-19T07:47:36Z

This PR breaks foliage transparency in X-men Origins

RSX capture

Xcedf · 2019-01-19T10:12:19Z

Confirm GoWIII exploding vertices particles fixed
Before:

After:

digitaldude555 · 2019-01-19T11:17:19Z

UI fixed!

kd-11 · 2019-01-19T11:19:26Z

The last commit needs a ton of work, a lot more than I initially anticipated, so this has been relegated to WIP while I finish the implementation. Should be ready in a few more days.

digitaldude555 · 2019-01-19T17:20:49Z

Displays crystals for the first time.

No more exploding vertices.

Xcedf · 2019-01-19T19:40:07Z

MotorStorm Pacific Rift, environment random exploding verices fixed

Illynir · 2019-01-19T20:41:56Z

Ni no kuni works perfectly for me, try of remove the shader cache.

frymezim · 2019-01-20T00:15:24Z

@Illynir
Your right, it's weird though I always move hdd_dev0 to a newer build with a fresh directory just to make sure that I won't have shader cache issue.

uaqlover · 2019-01-20T21:07:29Z

fix NASCAR The Game: Inside Line [BLUS30932] and little bit performance

before

after

kd-11 · 2019-01-21T20:28:39Z

Pushed a rewrite of the attrib frequency modifiers, hopefully nothing regressed. Retest games that were fixed by earlier versions of the PR to confirm everything is ok.

MarioSonic2987 · 2019-01-21T20:52:09Z

MCLA still has the improvements from this PR:

stride21 · 2019-01-21T23:05:11Z

Battlefield: Bad Company and Ratchet and Clank Future: Tools of Destruction regressions are now fixed. Motorstorm, Journey and Battlefield: Bad Company still have the improvements from this PR and Infamous 2 which regressed and was fixed earlier in this PR still looks the same as master.

- Do not compile body if the shader is of no consequence, leave as a passthrough shader

- Implement move and copy ctors

- Typo fix. I meant to disable scissor test, not stencil test - Also clean up and simplify/optimize the core logic

…-Q-R enums for texture coordinate space

kd-11 · 2019-01-22T22:00:02Z

Retest.

Aurez · 2019-01-22T22:33:48Z

It was quick !!

Fixed: Nice job!

stride21 · 2019-01-23T00:46:52Z

Journey regression is now fixed.

thx4ever · 2019-01-23T01:00:24Z

I tested RED DEAD REDEMPTION with this PR, and it dont get any further anymore, it stop emulator with this message: F {RSX [0x0148a24]} RSX: class std::runtime_error thrown: Verification failed (e=0x7f):
(in file c:\projects\rpcs3\rpcs3\emu\rsx\vk\vkoverlays.h:229), i don`t have tryed with opengl but vulkan it stops
Intel i7 7700
Nvidia Geforce GTX 1050
8GB RAM DDR4

Xcedf · 2019-01-23T06:22:00Z

@thx4ever flickerig polygon problem in Ghost Recon is also presented on master, and older builds, nothing to do with this PR

Kravickas · 2019-01-23T18:19:32Z

GTA V
OGL
Master: ok
PR: black screen
new error E {RSX [0x00452f0]} RSX: OOM Error: Ring buffer was likely being used without notify() being called
RPCS3.log.gz
GTA V 5565.zip

VK is ok

MarioSonic2987 · 2019-01-23T18:32:00Z

Fixes color regression caused by #5146 with OpenGL in Worms Crazy Golf.

Before:

After:

- Disable DEPTH<->RGBA typeless transfers for now as they require a lot more work to work for all vendors - Do not allow switching layouts to UNDEFINED/PREINITIALIZED formats

Kravickas · 2019-01-23T23:42:09Z

GTA V OGL fixed

MarioSonic2987 · 2019-01-24T14:06:23Z

Trees shadows are now correct in MCLA.

This comment has been minimized.

Sign in to view

kd-11 mentioned this pull request Jan 17, 2019

Deadstorm Pirates: Enemies have transparency issues #5567

Closed

kd-11 force-pushed the master branch from fd5e41c to f30f0fd Compare January 18, 2019 09:29

kd-11 force-pushed the master branch from f30f0fd to 2d606c7 Compare January 18, 2019 20:37

kd-11 changed the title ~~[Testers Needed] rsx: Fixups and improvements~~ [WIP][Testers Needed] rsx: Fixups and improvements Jan 19, 2019

kd-11 force-pushed the master branch from 2d606c7 to 8172b2f Compare January 21, 2019 20:27

kd-11 force-pushed the master branch from 0eb67e4 to 5bc8b39 Compare January 22, 2019 21:33

kd-11 added 5 commits January 23, 2019 00:58

rsx/fp: Detect broken/NOP shaders automatically

e964c79

- Do not compile body if the shader is of no consequence, leave as a passthrough shader

rsx: Reimplement attrib divisor

5b853e7

rsx: simple_array<T> improvements

682c11c

- Implement move and copy ctors

gl: Blit fixup

ea3b62f

- Typo fix. I meant to disable scissor test, not stencil test - Also clean up and simplify/optimize the core logic

gl: Remove GL_R 'format'. There is no GL_R format, it part of the S-T…

6453d70

…-Q-R enums for texture coordinate space

kd-11 force-pushed the master branch from 5bc8b39 to 6453d70 Compare January 22, 2019 21:59

This comment has been minimized.

Sign in to view

kd-11 mentioned this pull request Jan 23, 2019

Regressions from #5427 (FBO_Fixes) #5514

Closed

kd-11 added 2 commits January 24, 2019 00:40

rsx: Typo fix

c49534b

vk: Spec fixups

6efc71a

- Disable DEPTH<->RGBA typeless transfers for now as they require a lot more work to work for all vendors - Do not allow switching layouts to UNDEFINED/PREINITIALIZED formats

kd-11 force-pushed the master branch from 2884f26 to 6efc71a Compare January 23, 2019 21:58

gl: Fixup - inline arrays

ef39654

kd-11 merged commit 660bfea into RPCS3:master Jan 25, 2019

This was referenced Jan 25, 2019

NFL Blitz [NPUB30665] Field gfx have exploding vertices #5132

Closed

Double Dragon Neon [NPUB30764]: 2D background does not render properly #5517

Closed

This comment has been minimized.

Sign in to view

RainbowCookie32 mentioned this pull request Jan 26, 2019

inFamous [NPUA80480] crashes on Vulkan after #5565 #5600

Closed

jjsat mentioned this pull request Jan 29, 2019

Wolfenstein (2009) graphical ssue since #5427 - OpenGL only #5570

Closed

This comment has been minimized.

Sign in to view

rsx: Fixups and improvements #5565

rsx: Fixups and improvements #5565

Conversation

kd-11 commented Jan 16, 2019 • edited Loading

uaqlover commented Jan 16, 2019

digitaldude555 commented Jan 16, 2019 • edited Loading

stride21 commented Jan 16, 2019 • edited Loading

legend800 commented Jan 17, 2019

This comment has been minimized.

stride21 commented Jan 17, 2019

MarioSonic2987 commented Jan 18, 2019

stride21 commented Jan 18, 2019 • edited Loading

stride21 commented Jan 19, 2019

legend800 commented Jan 19, 2019 • edited Loading

legend800 commented Jan 19, 2019 • edited Loading

MarioSonic2987 commented Jan 19, 2019 • edited Loading

legend800 commented Jan 19, 2019 • edited Loading

MSuih commented Jan 19, 2019 • edited Loading

Xcedf commented Jan 19, 2019

digitaldude555 commented Jan 19, 2019

kd-11 commented Jan 19, 2019

digitaldude555 commented Jan 19, 2019

Xcedf commented Jan 19, 2019

Illynir commented Jan 19, 2019

frymezim commented Jan 20, 2019

uaqlover commented Jan 20, 2019 • edited Loading

kd-11 commented Jan 21, 2019

MarioSonic2987 commented Jan 21, 2019

stride21 commented Jan 21, 2019 • edited Loading

kd-11 commented Jan 22, 2019

Aurez commented Jan 22, 2019

This comment has been minimized.

stride21 commented Jan 23, 2019

thx4ever commented Jan 23, 2019

Xcedf commented Jan 23, 2019 • edited Loading

Kravickas commented Jan 23, 2019

MarioSonic2987 commented Jan 23, 2019 • edited Loading

Kravickas commented Jan 23, 2019

MarioSonic2987 commented Jan 24, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

kd-11 commented Jan 16, 2019 •

edited

Loading

digitaldude555 commented Jan 16, 2019 •

edited

Loading

stride21 commented Jan 16, 2019 •

edited

Loading

stride21 commented Jan 18, 2019 •

edited

Loading

legend800 commented Jan 19, 2019 •

edited

Loading

legend800 commented Jan 19, 2019 •

edited

Loading

MarioSonic2987 commented Jan 19, 2019 •

edited

Loading

legend800 commented Jan 19, 2019 •

edited

Loading

MSuih commented Jan 19, 2019 •

edited

Loading

uaqlover commented Jan 20, 2019 •

edited

Loading

stride21 commented Jan 21, 2019 •

edited

Loading

Xcedf commented Jan 23, 2019 •

edited

Loading

MarioSonic2987 commented Jan 23, 2019 •

edited

Loading