rsx: Fixes #5146

kd-11 · 2018-09-18T18:07:52Z

Blit Engine

Forcefully downloads and reuploads data from the CPU in case of unexpected overlaps
Properly detect correct size of newly created blit targets

Other

Fix flip source buffer selection
Fix resource readback for overlapping sections (WCB)
Fix flickering in OpenGL

Fixes #5135
Also fixes part of #4258

darkdragonz12 · 2018-09-18T19:36:31Z

in this pr detected blue background, with the game blazblue central fiction, although this no longer passes the menu remains frozen, not caused by this pr.

darkdragonz12 · 2018-09-18T20:03:53Z

God of war 3 same problem blue background.

kd-11 · 2018-09-18T20:11:35Z

Will fix the red-blue color swap soon.

Kazeira · 2018-09-18T23:20:18Z

Regression in Infamous 2

stride21 · 2018-09-19T00:43:01Z

This PR made Ratchet and Clank Future: Tools of Destruction go ingame and has fix the flicker issue in its cutscenes and main menu.

Kravickas · 2018-09-19T00:59:57Z

Retest against latest master, cos ratchet was fixed by other pr already merged

Delete comment after

ruipin · 2018-09-19T01:05:14Z

He is correct, this PR (the second commit) fixes the flashing menu in R&C ToD, as well as fixing the black screen once you go in-game. The PR that went to master only got the game to the menu reliably.

It might also fix bugs such as the DeS black/white flashes and other games with WCB where there is framebuffer flickering on Vulkan (OpenGL still has issue)

stride21 · 2018-09-19T01:06:14Z

Retest against latest master, cos ratchet was fixed by other pr already merged

Delete comment after

still has flickering during cutscenes and black screen when ingame on master

legend800 · 2018-09-19T01:55:10Z

Rayman Legends colors are purple now (unless you turn on WCB + Blit):

Note: Still flickers also from Dec 2017 regression.

greentop · 2018-09-19T02:37:34Z

Ubuntu 18.04 - Nvidia 396.54

RPCS3.log.gz

kd-11 · 2018-09-19T05:28:56Z

I'll let you know when the blue is fixed so please don't spam reports.

elad335 · 2018-09-19T08:56:41Z

Not sure if this is a progression or regression, but this pr fixes white, green and more colored rectangles with TLoU, the only ones that remain are orange. This is not random and is reproducible on every run.

kd-11 · 2018-09-19T20:33:09Z

Blue color bug should have been fixed, time to retest.

greentop · 2018-09-19T20:57:39Z

TOCS2 & Hyperdimension Neptunia color issues are fixed as of c852d5c.

elhaya · 2018-09-19T21:06:46Z

i concur - with the last commit, gow 3 blue screen is gone (without having to use cpu blit)

raveskirza · 2018-09-19T21:08:59Z

B2S ingame-->Loadable

Crashes with below message
F {rsx::thread} class std::runtime_error thrown: Verification failed (e=0x7e):
(in file c:\projects\rpcs3\rpcs3\emu\rsx\rsx_cache.h:100)

RPCS3.log_Master.gz
RPCS3.log_PR.gz

kd-11 · 2018-09-19T22:23:36Z

@raveskirza I'm not fixing validation errors in this PR as ruipin's PR restructures the whole cache and automatically avoids such situations. Adding more temporary workarounds isn't too great an idea.

kd-11 · 2018-09-19T22:35:55Z

Verification error will be analysed further and I will decide whether to patch it now or wait for the refactoring. Looks like this is still WIP for now.

elhaya · 2018-09-20T04:46:36Z

@kd-11 i'm experiencing slowdowns, even to a complete crawl (2fps) with some of the games i tested.
for example, risen 3 and rdr, when using opengl. i have nvidia btw, maybe it has to do with your workaround?

- Forcefully downloads and reuploads data from the CPU in case of unexpected overlaps - Properly detect correct size of newly created blit targets - Remember to clear any existing views when changing the default component map!

- Orders flushing to preserve memory at all cost - Avoids false positive where flushing overlapping sections can falsely invalidate another with head/tail test

kd-11 · 2018-09-20T16:23:04Z

Yea, the degraded performance is due to another issue where glCheckFramebuffer is returning success even when the attachments are removed via glDeleteTextures. A proper fix is incoming.

kd-11 · 2018-09-20T19:16:31Z

The performance regression should be fixed now. Turns out the driver is reusing texture handles and CheckFramebuffer is not actually checking to see if the handle is the same one used when attaching. Switched to manually tracking usage and attachment refs and the problem is now gone.

- Matching attachments with resource id fails because drivers are reusing handles! - Properly sets up stale fbo ref counting and removal - Properly sets up resource reference test with subsequent removal to avoid using a broken fbo entry

- Removes all use of valid_count as a metric until the new refactor is merged

HerrHulaHoop · 2018-09-20T20:33:23Z

Confirmed, this PR fixed regression reported in #5001 where screen flickering was visible in Terraria [BLES01938] when using OpenGL after #4973

isshininu · 2018-09-20T20:49:25Z

This PR fixed DeS Valley of Defilement on OpenGL, when it was sometimes too much dark,

Before

I want to open issue about this just yestereday
P.S. Love when my issues resolved before I reported them <:3

rekongstor · 2018-09-20T20:57:15Z

Fixes #4348

ruthan · 2018-09-21T15:06:27Z

I can confirm that Golden Axe Beast rider issue is fixed, i can load first level and see cutscene, but after i get only black screen a hear game sounds..
RPCS3.zip

It's easier to rebase that PR on top of RPCS3#5115 than vice-versa

- Forcefully downloads and reuploads data from the CPU in case of unexpected overlaps - Properly detect correct size of newly created blit targets - Remember to clear any existing views when changing the default component map! (From PR RPCS3#5146)

(From PR RPCS3#5146)

- Orders flushing to preserve memory at all cost - Avoids false positive where flushing overlapping sections can falsely invalidate another with head/tail test (From PR RPCS3#5146)

- Matching attachments with resource id fails because drivers are reusing handles! - Properly sets up stale fbo ref counting and removal - Properly sets up resource reference test with subsequent removal to avoid using a broken fbo entry (From PR RPCS3#5146)

MarioSonic2987 · 2018-09-22T06:36:06Z

Fixes flickering graphics in Sonic Generations.

Before (changes between good and black graphics):

After:

MarioSonic2987 · 2018-09-25T12:27:10Z

In Worms Crazy Golf, fixes 2/3 screen issue in Vulkan, but breaks color with OpenGL.

Before:

After:

Edit: Worms Revolution is also affected by this PR in a similar way.

kd-11 changed the title ~~[Testers Needed] rsx: blit engine fixes~~ [WIP] rsx: blit engine fixes Sep 18, 2018

kd-11 changed the title ~~[WIP] rsx: blit engine fixes~~ [WIP] rsx: Fixes Sep 18, 2018

kd-11 added 3 commits September 20, 2018 15:05

rsx; blit engine fixes

f91bed7

- Forcefully downloads and reuploads data from the CPU in case of unexpected overlaps - Properly detect correct size of newly created blit targets - Remember to clear any existing views when changing the default component map!

rsx: Fix flip source selector

2b9d70d

rsx: Preserve memory order when doing flush

7b7c5a3

- Orders flushing to preserve memory at all cost - Avoids false positive where flushing overlapping sections can falsely invalidate another with head/tail test

kd-11 force-pushed the rsx_volatile branch 2 times, most recently from c883f7d to cbf58df Compare September 20, 2018 14:08

kd-11 force-pushed the rsx_volatile branch from cbf58df to 3c7926d Compare September 20, 2018 19:09

kd-11 mentioned this pull request Sep 20, 2018

Regressions introduced on #4973 #5001

Closed

kd-11 added 2 commits September 20, 2018 22:20

gl: Fix problems with framebuffer reuse

b1ed8a8

- Matching attachments with resource id fails because drivers are reusing handles! - Properly sets up stale fbo ref counting and removal - Properly sets up resource reference test with subsequent removal to avoid using a broken fbo entry

rsx: temporary hack

99d6711

- Removes all use of valid_count as a metric until the new refactor is merged

kd-11 changed the title ~~[WIP] rsx: Fixes~~ rsx: Fixes Sep 20, 2018

kd-11 force-pushed the rsx_volatile branch from 3c7926d to 99d6711 Compare September 20, 2018 19:22

rekongstor mentioned this pull request Sep 20, 2018

[BLUS30701] Hyperdimension Neptunia - Corrupted dialogue textures #4348

Closed

Merge branch 'master' into rsx_volatile

d4ef90a

kd-11 merged commit dafc914 into RPCS3:master Sep 21, 2018

MsDarkLow mentioned this pull request Sep 21, 2018

Yakuza Games bugs #4489

Open

11 tasks

ruipin added a commit to ruipin/rpcs3 that referenced this pull request Sep 22, 2018

Revert PR RPCS3#5146 temporarily

1b2a0da

It's easier to rebase that PR on top of RPCS3#5115 than vice-versa

ruipin pushed a commit to ruipin/rpcs3 that referenced this pull request Sep 22, 2018

rsx: Fix flip source selector

e0714d6

(From PR RPCS3#5146)

ruipin mentioned this pull request Sep 22, 2018

Texture Cache cleanup/refactoring & fixes #5115

Merged

MSuih mentioned this pull request Oct 17, 2018

Regression: LittleBigPlanet 2 & 3 after #5146 #5259

Closed

MarioSonic2987 mentioned this pull request Jan 23, 2019

rsx: Fixups and improvements #5565

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rsx: Fixes #5146

rsx: Fixes #5146

kd-11 commented Sep 18, 2018 •

edited

Loading

darkdragonz12 commented Sep 18, 2018 •

edited

Loading

darkdragonz12 commented Sep 18, 2018

kd-11 commented Sep 18, 2018

Kazeira commented Sep 18, 2018

stride21 commented Sep 19, 2018

Kravickas commented Sep 19, 2018 •

edited

Loading

ruipin commented Sep 19, 2018 •

edited

Loading

stride21 commented Sep 19, 2018 •

edited

Loading

legend800 commented Sep 19, 2018 •

edited

Loading

greentop commented Sep 19, 2018

kd-11 commented Sep 19, 2018

elad335 commented Sep 19, 2018 •

edited

Loading

kd-11 commented Sep 19, 2018

greentop commented Sep 19, 2018 •

edited

Loading

elhaya commented Sep 19, 2018

raveskirza commented Sep 19, 2018

kd-11 commented Sep 19, 2018

kd-11 commented Sep 19, 2018

elhaya commented Sep 20, 2018

kd-11 commented Sep 20, 2018

kd-11 commented Sep 20, 2018

HerrHulaHoop commented Sep 20, 2018

isshininu commented Sep 20, 2018 •

edited

Loading

rekongstor commented Sep 20, 2018

ruthan commented Sep 21, 2018

MarioSonic2987 commented Sep 22, 2018 •

edited

Loading

MarioSonic2987 commented Sep 25, 2018 •

edited

Loading

rsx: Fixes #5146

rsx: Fixes #5146

Conversation

kd-11 commented Sep 18, 2018 • edited Loading

darkdragonz12 commented Sep 18, 2018 • edited Loading

darkdragonz12 commented Sep 18, 2018

kd-11 commented Sep 18, 2018

Kazeira commented Sep 18, 2018

stride21 commented Sep 19, 2018

Kravickas commented Sep 19, 2018 • edited Loading

ruipin commented Sep 19, 2018 • edited Loading

stride21 commented Sep 19, 2018 • edited Loading

legend800 commented Sep 19, 2018 • edited Loading

greentop commented Sep 19, 2018

kd-11 commented Sep 19, 2018

elad335 commented Sep 19, 2018 • edited Loading

kd-11 commented Sep 19, 2018

greentop commented Sep 19, 2018 • edited Loading

elhaya commented Sep 19, 2018

raveskirza commented Sep 19, 2018

kd-11 commented Sep 19, 2018

kd-11 commented Sep 19, 2018

elhaya commented Sep 20, 2018

kd-11 commented Sep 20, 2018

kd-11 commented Sep 20, 2018

HerrHulaHoop commented Sep 20, 2018

isshininu commented Sep 20, 2018 • edited Loading

rekongstor commented Sep 20, 2018

ruthan commented Sep 21, 2018

MarioSonic2987 commented Sep 22, 2018 • edited Loading

MarioSonic2987 commented Sep 25, 2018 • edited Loading

kd-11 commented Sep 18, 2018 •

edited

Loading

darkdragonz12 commented Sep 18, 2018 •

edited

Loading

Kravickas commented Sep 19, 2018 •

edited

Loading

ruipin commented Sep 19, 2018 •

edited

Loading

stride21 commented Sep 19, 2018 •

edited

Loading

legend800 commented Sep 19, 2018 •

edited

Loading

elad335 commented Sep 19, 2018 •

edited

Loading

greentop commented Sep 19, 2018 •

edited

Loading

isshininu commented Sep 20, 2018 •

edited

Loading

MarioSonic2987 commented Sep 22, 2018 •

edited

Loading

MarioSonic2987 commented Sep 25, 2018 •

edited

Loading