-
-
Notifications
You must be signed in to change notification settings - Fork 69
Format commands .qubesbuilder in single quotes #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When formatted in double quotes, the @SOURCE_DIR@ may be problematic with windows builder, as it will contain backslashes, and that will be misinterpreted by the yaml parser. While the windows paths are not relevant for those commands, .qubesbuilder file need to render correctly in that case too.
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025043016-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031804-4.3&flavor=update
Failed tests8 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/132953#dependencies 14 fixed
Unstable testsPerformance TestsPerformance degradation:No issues Remaining performance tests:No remaining performance tests |
When formatted in double quotes, the @SOURCE_DIR@ may be problematic
with windows builder, as it will contain backslashes, and that will be
misinterpreted by the yaml parser. While the windows paths are not
relevant for those commands, .qubesbuilder file need to render correctly
in that case too.