Skip to content

Commit 2bed45c

Browse files
committed
Make Devices tab prettier & safer
- Hide `Host Bridge` and `PCI Bridge` devices since connecting them to a qube would prevent it from booting - If `port_id` is a path, replace the `-` delimiter with ` -> ` to make it prettier and more meaningful Related: QubesOS/qubes-issues#8681
1 parent 6d7ac61 commit 2bed45c

File tree

1 file changed

+13
-4
lines changed

1 file changed

+13
-4
lines changed

qubesmanager/settings.py

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1381,9 +1381,14 @@ def __init_devices_tab__(self):
13811381
self.devices_layout.addWidget(self.dev_list)
13821382

13831383
try:
1384-
dom0_devs = \
1385-
list(self.vm.app.domains['dom0'].
1386-
devices['pci'].get_exposed_devices())
1384+
dom0_devs = list(
1385+
dev
1386+
for dev in self.vm.app.domains["dom0"]
1387+
.devices["pci"]
1388+
.get_exposed_devices()
1389+
if dev.interfaces[0].category
1390+
!= device_protocol.DeviceCategory.PCI_Bridge
1391+
)
13871392
attached = list(
13881393
self.vm.devices['pci'].get_assigned_devices(required_only=True))
13891394
except qubesadmin.exc.QubesException:
@@ -1395,7 +1400,11 @@ def __init_devices_tab__(self):
13951400
class DevListWidgetItem(QtWidgets.QListWidgetItem):
13961401
def __init__(self, dev, unknown=False, parent=None):
13971402
super().__init__(parent)
1398-
name = dev.port_id.replace('_', ":") + ' ' + dev.description
1403+
name = (
1404+
dev.port_id.replace("_", ":").replace("-", " -> ")
1405+
+ " "
1406+
+ dev.description
1407+
)
13991408
if unknown:
14001409
name += ' (unknown)'
14011410
self.setText(name)

0 commit comments

Comments
 (0)