Allow user to save valid modified policy on 1st char #256
Conversation
alimirjamali
force-pushed
the
issue-9911-policy-1st-modification
branch
from
d0ba4f3 to
fc00fde
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #256 +/- ##
=======================================
Coverage 92.67% 92.67%
=======================================
Files 59 59
Lines 11267 11268 +1
=======================================
+ Hits 10442 10443 +1
Misses 825 825 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025052004-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025021804-4.3&flavor=update
Failed tests18 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/129058#dependencies 15 fixed
Unstable testsPerformance TestsPerformance degradation:No issues Remaining performance tests:56 tests
|
|
Hm, I'd rather have here correct checking for changes then just ignoring it. Maybe there is another signal handler, or maybe this should be connected to 'modified-changed' signal? |
Checking for `get_modified()` within signal handler for `changed` signal does not work for the 1st character (e.g. commenting a policy line) as the output of `get_modified()` only changes after the signal handler. fixes: QubesOS/qubes-issues#9911
alimirjamali
force-pushed
the
issue-9911-policy-1st-modification
branch
from
fc00fde to
be1f977
Compare
Just tested this. It will work fine if it is connected to both |
Checking for
get_modified()within signal handler forchangedsignaldoes not work for the 1st character (e.g. commenting a policy line)
as the output of
get_modified()only changes after the signal handler.fixes: QubesOS/qubes-issues#9911