Releasing 1.0.0 #45
Merged
Releasing 1.0.0 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
anchal-physics
commented
May 6, 2024
anchal-physics
commented
- Depends on IMASDD now. All previous versions will become unsupported once OMAS is deprecated.
- Added documentation
When interferometer was plotted over a heatmap of a 2D visualization, like electorn density, the new plot was not automatically inheriting the layout from the heatmap. This had a simple fix by defaulting the plotting of interferometer and space objects on subplot number 1. This commit fixes ProjectTorreyPines/SOLPS2ctrl.jl#39
Added makefile that correctly clones repos or use git urls to generate a functioning set of toml files so that private projects can be accessed easily.
Adding makefile for building Julia environment
Fixed overlaying issues and updated examples
make r option now checks if it is called from inside a repo that is present in .julia/dev and if present there, it clones the dependent repos without the .jl extension. It also runs dvc pull to ensure sample files have been pulled
makefile clones without .jl in .julia/dev and more
Quick bug fix while plotting subset with cells
OMAS was replaced with IMASDD in makefile but since the currently we are simply importing OMAS as IMASDD, we need to add back OMAS in the makefile. I have left IMASDD in the makefile as well, so that we can easily switch between the two in future. I've tested this make version on my machine.
Replace OMAS with IMASDD in GGDUtils
Modifty get_grid_subset_with_index. Rename it to get_grid_subset and a a second function that accepts the name as a string. Changes to be committed: modified: src/interpolations.jl modified: src/recipes.jl modified: src/subset_tools.jl Original Author: +Alicia Dautt-Silva <dauttsilvaa@omega-a.gat.com> rebased by: Anchal Gupta <guptaa@fusion.gat.com>
Original Author: +Alicia Dautt-Silva <dauttsilvaa@omega-a.gat.com> Rebased by: Anchal Gupta AG: Such bad commit message.
Make translator between grid subset names and indices
* All references to OMAS have been removed now. * All tests pass with IMASDD and all exmaples run.
Final switch to IMASDD
Now make r will clone dependent project repos without the .jl extension by default. The unnecessary complexity of detection of .julia/dev path has been removed. This is to address ProjectTorreyPines/SOLPS2imas.jl#33
make r will clone repo without .jl extension Simple fix, not asking for review.
Based on quick bug fixes in SOLPS2IMAS: ProjectTorreyPines/SOLPS2imas.jl@e852997 ProjectTorreyPines/SOLPS2imas.jl@ff8a119 The sample files were updated and grid_subset_index was updated in the runtest.jl.
For projection from higher dimension to lower dimension subsets, the function project_prop_on_subset!() whill now use thin plate spline interpolation to project the property values. The matrcies required can be provided as keyword argument in case this function is called multiple times for same grid geometry.
Using TPS mats interpolation while projection
* make_docs workflow has been added to generate online documentation * docstrings have been added and edited to make the documentation more informative and clear.
Co-authored-by: Orso Meneghini <orso82@gmail.com>
Adding documentation and updated licence to Apache 2.0
* Incremented major version, version number is now 1.0.0
* All previous versions will become unsupported once OMAS is deprecated
* The documentor will source dev documentation from the dev branch and release documentation from the master branch
Triggered at: * For pushing changes to master or dev branches * For pull requests to master or dev branches Features: * Uses Julia 1.9.3 (we can change or increase number of versions to be tested and supported later) * Uses ubuntu-latest in x86 architecture * Uses DVC to pull sample files (login to cybele using guptaa account) * Runs test using julia's native test feature. * CodeCov needs to be setup for reporting code coverage of the tests.
eldond
approved these changes
May 7, 2024
Adding CI Test for PR by using Github Actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.