Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed overlaying issues and updated examples #35

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Fixed overlaying issues and updated examples #35

merged 3 commits into from
Feb 16, 2024

Conversation

anchal-physics
Copy link
Collaborator

This PR fixes ProjectTorreyPines/SOLPS2ctrl.jl#39

The main issue was that when itnerferometer was overlaid, it was not inheriting the layout properly from 2 panel layout of the heatmap.

Following works now:

gr()

n_e = GGDUtils.get_prop_with_grid_subset_index(ids.edge_profiles.ggd[1].electrons.density, 5)
plot(ids.edge_profiles.grid_ggd, n_e, colorbar_title="Electrons density / m^(-3)", left_margin=10Plots.pt)
plot!(space)
plot!(ids.interferometer, legend=true, size=[635, 900]) # Adding a size comment to make plot aspect ratio better

interferometer_electron_density

@anchal-physics
Fixed issue of layout problems with interferometer
f175d91 
When interferometer was plotted over a heatmap of a 2D visualization,
like electorn density, the new plot was not automatically inheriting
the layout from the heatmap. This had a simple fix by defaulting the
plotting of interferometer and space objects on subplot number 1. This
commit fixes
ProjectTorreyPines/SOLPS2ctrl.jl#39
@anchal-physics
Increasing plot width to get same aspect ratio for heatmaps
0001934
@anchal-physics
Updated examples to show use of left_margin and overlaying
8da838d
@anchal-physics anchal-physics changed the base branch from master to dev February 14, 2024 06:23
@anchal-physics anchal-physics mentioned this pull request Feb 14, 2024
Merged
@anchal-physics anchal-physics merged commit f84b151 into dev Feb 16, 2024
1 check passed
@eldond eldond deleted the 2DVis branch February 16, 2024 15:14
@anchal-physics anchal-physics mentioned this pull request Mar 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldond eldond eldond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plot display issues: some elements do not appear, multiple legends, etc.
2 participants
@anchal-physics @eldond