Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding documentation and updated licence to Apache 2.0 #44

Merged
merged 7 commits into from
May 6, 2024
Merged

Conversation

anchal-physics
Copy link
Collaborator

  • make_docs workflow has been added to generate online documentation from source code
  • docstrings were added and edited for succesfull generation of documentation.
  • Licence has been changed to Apache 2.0 with a Notice file to cite proceedings in PSI 2024 for academic publications.

@anchal-physics anchal-physics requested a review from eldond May 1, 2024 23:04
* make_docs workflow has been added to generate online documentation
* docstrings have been added and edited to make the documentation
  more informative and clear.
Copy link
Member

@orso82 orso82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Well done!

LICENSE Outdated Show resolved Hide resolved
Co-authored-by: Orso Meneghini <orso82@gmail.com>
Copy link
Contributor

@eldond eldond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just update the paper reference (at least NME instead of PSI, but you can take it farther if you want) and then this is fine. Good work, thanks.

NOTICE.md Outdated Show resolved Hide resolved
@anchal-physics anchal-physics merged commit e620e58 into dev May 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants