-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ImportError for IgniteInfo #1747
Conversation
are these changes not needed anymore? |
Hi @SachidanandAlle, no, the change still need, but it may need the next release from monai to help ci pass. Thanks. |
Hi @SachidanandAlle and @tangy5, we may need drop python 3.8 support here since monai has dropped so it can not install 1.4.0rc in the ci. |
Since the setting in the workflow only use the one on the main branch, ci can still not pass. Will leave this pr here since I don't want change too much in the config yaml for monailabel.
I also have a workaround in monai core already merged, Project-MONAI/MONAI#8121 So we can leave the pr here and update it later. |
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
for more information, see https://pre-commit.ci Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
updates: - [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0) - [github.com/psf/black: 24.3.0 → 24.4.2](psf/black@24.3.0...24.4.2) - [github.com/psf/black: 24.3.0 → 24.4.2](psf/black@24.3.0...24.4.2) - [github.com/PyCQA/flake8: 7.0.0 → 7.1.0](PyCQA/flake8@7.0.0...7.1.0) - [github.com/pre-commit/mirrors-mypy: v1.9.0 → v1.10.1](pre-commit/mirrors-mypy@v1.9.0...v1.10.1) - [github.com/asottile/pyupgrade: v3.15.2 → v3.16.0](asottile/pyupgrade@v3.15.2...v3.16.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: SACHIDANAND ALLE <sachidanand.alle@gmail.com> Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.2.1 to 2.2.2. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@2.2.1...2.2.2) --- updated-dependencies: - dependency-name: urllib3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Bumps [requests](https://github.com/psf/requests) from 2.31.0 to 2.32.2. - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.31.0...v2.32.2) --- updated-dependencies: - dependency-name: requests dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Pinning basic packages such as "requests" to a specific patch level release such "2.31.0" is too strict. New releases and especially new patch releases allow to use latest security updates of various packages. Signed-off-by: James Butler <james.butler@revvity.com> Co-authored-by: SACHIDANAND ALLE <sachidanand.alle@gmail.com> Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
* Release 0.8.4 checks and updates Signed-off-by: tangy5 <yuchengt@nvidia.com> * Trigger monai container update Signed-off-by: tangy5 <yuchengt@nvidia.com> * Drop python 3.8 Signed-off-by: tangy5 <yuchengt@nvidia.com> * Drop python 3.8 Signed-off-by: tangy5 <yuchengt@nvidia.com> --------- Signed-off-by: tangy5 <yuchengt@nvidia.com> Co-authored-by: tangy5 <yuchengt@nvidia.com> Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: Ashis Ravindran <ashis.ravindran@dkfz-heidelberg.de> Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
* Add MITK as supported platform Signed-off-by: Ashis Ravindran <ashis.ravindran@dkfz-heidelberg.de> * Update link to MONAI Label repo Signed-off-by: Ashis Ravindran <ashis.ravindran@dkfz-heidelberg.de> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Ashis Ravindran <ashis.ravindran@dkfz-heidelberg.de> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Using transforms from MONAI and MONAILabel can result in metadata containing torch.tensors and torch.Sizes. This change fixes a traceback in the restored transform resulting from an incompatibility between torch datatypes and numpy.any(). Signed-off-by: Thomas Kierski <thomas.kierski@revvity.com> Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
This reverts commit 8ced475. Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Hi @tangy5, this one can be merged now. Thanks. |
Fix issue caused by Project-MONAI/MONAI#8113