Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IgniteInfo can not import issue #8121

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Sep 30, 2024

Fixes #8120 .

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Sep 30, 2024

/build

1 similar comment
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Sep 30, 2024

/build

@mingxin-zheng
Copy link
Contributor

Hi @KumoLiu , do you think we'll need to change this line too?

OPT_IMPORT_VERSION = "0.4.4"

The version of Ignite in requirements-dev.txt is 0.4.11

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Sep 30, 2024

/build

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Sep 30, 2024

/build

@mingxin-zheng
Copy link
Contributor

mingxin-zheng commented Sep 30, 2024

By the way, do you think a deprecated class should also be included in the __all__ definitions?

I don't have a strong opinion on this. Either way makes sense.

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Sep 30, 2024

By the way, do you think a deprecated class should also be included in the __all__ definitions?

Yes, added.

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Sep 30, 2024

/build

@KumoLiu KumoLiu merged commit 76ef9f4 into Project-MONAI:dev Sep 30, 2024
28 checks passed
@KumoLiu KumoLiu deleted the ignite-fix branch September 30, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot import name 'IgniteInfo' from 'monai.config'
2 participants