Master filter #2254
Draft
Master filter #2254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of creating a map
…or comparison operators on list)
…/Raphtory into features/window_filter_semantics
* impl node py filter iter * chore: apply tidy-public auto-fixes * impl path_from_graph, path_from_node, edges, nested_edges py filter, fix tests, * rid iter_graph * add more tests * add more tests * add exploded edges test --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'GraphQL Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 2c43237 | Previous: f14de7d | Ratio |
|---|---|---|---|
addNode |
17 req/s |
1460 req/s |
85.88 |
This comment was automatically generated by workflow using github-action-benchmark.
* impl node id filter * impl node id filter for gql * impl edge src/dst id filter * chore: apply tidy-public auto-fixes * add validations, support numeric, string filters for ids * rid dead code * add review changes * fix options --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: f36ed66 | Previous: db0c971 | Ratio |
|---|---|---|---|
lotr_graph_window_50_layered/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_persistent_window_50_layered/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
This comment was automatically generated by workflow using github-action-benchmark.
* impl qualifier filters for list properties and metadata * impl python, graphql qualifier filter, add tests * rename gql from gql object names, throw error if prop not found * ref * add more suggestions * allow empty graph in tests * allow empty graphs for tests * fix test
* impl aggs for temporal properties, add tests * add review suggestions
* redesign, refactor property filters * takes a reference * rework validation * fix arbitrary list, fix tests * merge python traits, fix tests, add more validations * rework gql filtering apis, fix tests * add review suggestions * Features/gql apis (#2350) * impl nodes select filtering in gql * change semantics of filters in gql, add missing filter apis in edges, fix all tests * add more edge filter tests * add filtering to path from node, add tests * fix apply views * rename filter-iter to select * add select as args * impl window filter (#2359) * impl window filter * impl window filter in python, add tests * impl gql window filter, add tests * ref * impl review suggestions * fixes * fix py and gql * add review suggestions
Collaborator
Author
|
Search nodes APIs are essentially nodes select instead of graph node filter because graph filter applies to subgraph which may filter edges and resultantly nodes depending upon how graph was created: |
* redesign, refactor property filters * takes a reference * rework validation * fix arbitrary list, fix tests * merge python traits, fix tests, add more validations * rework gql filtering apis, fix tests * impl nodes select filtering in gql * change semantics of filters in gql, add missing filter apis in edges, fix all tests * add more edge filter tests * add filtering to path from node, add tests * impl window filter * impl window filter in python, add tests * impl gql window filter, add tests * ref * impl edge node filtering, add few tests * rid redundant code * fix call to filter nodes * rid dead code * Integrating edge endpoint filtering mechanism into Python using the same wrapper types as node filtering. * Added src/dst endpoint filtering support for exploded edge filters in rust and python * Added src/dst endpoint filtering support for exploded edge filters in GraphQL and fixed search * Added tests from previous branch, some of them fail * Fixed DynFilterOps implementations for EndpointWrapper<T> types. Endpoint filtering tests pass * Changed many impls to be blanket implementations using traits, especially EndpointWrapper<T> types. Use indexes in search on edge endpoints using NodeFilterExecutor. * rid dead code * nodeops suggestions from lucas * start fixing some apis * fixed most of the compilation errors * fix all the python problems except for actually implementing the python filtering * finish ref, fix tests * redone * fix * more changes * start fixing infinite trait bound recursion * rid filtered graphs * rid nodetypefilteredgraph * add review suggestions * fix infinite type recursion * fmt, fix recursion issue in search * impl py * Do not rely on Wrap for the trait bounds in the builder API as the compiler cannot figure out the bounds when trying to implement python wrappers. * fix gql, tests --------- Co-authored-by: arienandalibi <arienandalibi2@gmail.com> Co-authored-by: Lucas Jeub <lucas.jeub@pometry.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old PR : #2183
Fixes #1941
Fixes #2211
Fixes #2234