impl window filter #2359
Merged
impl window filter #2359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljeub-pometry
requested changes
Oct 31, 2025
Collaborator
ljeub-pometry
left a comment
ljeub-pometry
left a comment
There was a problem hiding this comment.
Rearchitect Windowed such that it wraps everything which should simplify a lot of the code and also make it much easier to extend to Layered
|
|
||
| #[staticmethod] | ||
| fn window(py_start: Bound<PyAny>, py_end: Bound<PyAny>) -> PyResult<PyEdgeWindow> { | ||
| let s = py_into_millis(&py_start)?; |
Collaborator
There was a problem hiding this comment.
there should already be support for doing this, it might be TimeIndexComponent
Collaborator
Author
There was a problem hiding this comment.
Replace this with TimeIndexComponent when merged from master.
|
|
||
| #[pyclass(frozen, name = "NodeWindow", module = "raphtory.filter")] | ||
| #[derive(Clone)] | ||
| pub struct PyNodeWindow(pub Windowed<NodeFilter>); |
Collaborator
There was a problem hiding this comment.
PyNodeWindow/EdgeWindow/ExplodedEdgeWindow can probably be replaced with dynamic dispatch eventually but it is a bit more tricky
ljeub-pometry
requested changes
Nov 4, 2025
Collaborator
ljeub-pometry
left a comment
ljeub-pometry
left a comment
There was a problem hiding this comment.
almost there, just some minor things to fix
shivamka1
added a commit
that referenced
this pull request
Nov 6, 2025
* impl nodes select filtering in gql * change semantics of filters in gql, add missing filter apis in edges, fix all tests * add more edge filter tests * add filtering to path from node, add tests * fix apply views * rename filter-iter to select * add select as args * impl window filter (#2359) * impl window filter * impl window filter in python, add tests * impl gql window filter, add tests * ref * impl review suggestions * fixes * fix py and gql * add review suggestions
shivamka1
added a commit
that referenced
this pull request
Nov 6, 2025
* redesign, refactor property filters * takes a reference * rework validation * fix arbitrary list, fix tests * merge python traits, fix tests, add more validations * rework gql filtering apis, fix tests * add review suggestions * Features/gql apis (#2350) * impl nodes select filtering in gql * change semantics of filters in gql, add missing filter apis in edges, fix all tests * add more edge filter tests * add filtering to path from node, add tests * fix apply views * rename filter-iter to select * add select as args * impl window filter (#2359) * impl window filter * impl window filter in python, add tests * impl gql window filter, add tests * ref * impl review suggestions * fixes * fix py and gql * add review suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2261