impl qualifier filters for list properties and metadata #2284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljeub-pometry
requested changes
Sep 24, 2025
Collaborator
ljeub-pometry
left a comment
ljeub-pometry
left a comment
There was a problem hiding this comment.
We should have a look if we can implement this using some traits so we don't have quite so much repetition
ljeub-pometry
requested changes
Sep 25, 2025
Collaborator
ljeub-pometry
left a comment
ljeub-pometry
left a comment
There was a problem hiding this comment.
some minor things to tweak and tests to fix
python/tests/test_base_install/test_filters/semantics/test_edge_property_filter_semantics.py
Outdated
Show resolved
Hide resolved
ljeub-pometry
approved these changes
Sep 26, 2025
Collaborator
ljeub-pometry
left a comment
ljeub-pometry
left a comment
There was a problem hiding this comment.
probably want to generalise the node tests so they also work with strings but looks good otherwise
…ory into features/qualifiers_filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2255