Replace PassThrough with removeNaNFromPointCloud in 3 tutorials #4760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- and adapt corresponding rst files - the PassThrough was a bad choice because it removes (large) parts of the clouds that should be segmented - for region_growing_rgb_segmentation this messes up the whole tutorial - for region_growing_segmentation this would be a problem if the result of the PassThrough would not be discarded - removeNaNFromPointCloud is the right choice since it only removes the invalid points, and it still serves as an example that the segmentation classes can work with indices
mvieth
added
needs: code review
larshg
approved these changes
May 16, 2021
kunaltyagi
approved these changes
May 17, 2021
kunaltyagi
added
changelog: fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see commit messages
Fixes #1752
Supersedes and closes #2302