Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[common] modify index types for PCLPointCloud2 #4199

Merged
merged 4 commits into from
Aug 14, 2020
Merged

[common] modify index types for PCLPointCloud2 #4199

merged 4 commits into from
Aug 14, 2020

Conversation

haritha-j
Copy link
Contributor

@haritha-j haritha-j commented Jun 16, 2020 •
edited
Loading

The cloud data here is std::vector<std::uint8_t>. @kunaltyagi should this be changed as well?

@haritha-j haritha-j added priority: gsoc Reason for prioritization module: common labels Jun 16, 2020
@kunaltyagi kunaltyagi added the changelog: ABI break Meta-information for changelog generation label Jun 16, 2020
@kunaltyagi kunaltyagi added this to the pcl-1.12.0 milestone Jun 16, 2020
@kunaltyagi kunaltyagi added the needs: code review Specify why not closed/merged yet label Jun 16, 2020
@kunaltyagi
Copy link
Member

should this be changed as well?

Could you please elaborate on this?

@haritha-j
Copy link
Contributor Author

Could you please elaborate on this?

Sorry, misunderstanding on my part.

@haritha-j haritha-j closed this Jun 16, 2020
@kunaltyagi
Copy link
Member

Closed by accident?

@haritha-j
Copy link
Contributor Author

haritha-j commented Jun 16, 2020 •
edited
Loading

Closed by accident?

Yep. They really shouldn't put that button so close to the comment button.

@haritha-j haritha-j reopened this Jun 16, 2020
@kunaltyagi
Copy link
Member

kunaltyagi commented Jun 16, 2020 •
edited
Loading

They really shouldn't put that button so close to the comment button

I use refined GitHub plugin which moves them to different sides (left and right)

SergioRAgostinho
SergioRAgostinho reviewed Jun 22, 2020
View reviewed changes
@SergioRAgostinho SergioRAgostinho added needs: author reply Specify why not closed/merged yet and removed needs: code review Specify why not closed/merged yet labels Jun 22, 2020
kunaltyagi
kunaltyagi reviewed Jun 23, 2020
View reviewed changes
SergioRAgostinho
SergioRAgostinho approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@SergioRAgostinho SergioRAgostinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address Kunal's last items and it's good to merge from my side.

@SergioRAgostinho SergioRAgostinho removed the needs: author reply Specify why not closed/merged yet label Jun 29, 2020
@stale
Copy link

stale bot commented Jul 29, 2020

Marking this as stale due to 30 days of inactivity. Commenting or adding a new commit to the pull request will revert this.

@stale stale bot added the status: stale label Jul 29, 2020
@kunaltyagi kunaltyagi merged commit 279232d into PointCloudLibrary:master Aug 14, 2020
@haritha-j haritha-j mentioned this pull request Aug 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larshg larshg larshg left review comments

@SergioRAgostinho SergioRAgostinho SergioRAgostinho approved these changes

@kunaltyagi kunaltyagi kunaltyagi approved these changes

Assignees
No one assigned
Labels
changelog: ABI break Meta-information for changelog generation module: common priority: gsoc Reason for prioritization status: stale
Projects
None yet
Milestone
pcl-1.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@haritha-j @kunaltyagi @larshg @SergioRAgostinho