TODO: <Modify index type for pointCloud> #4198

haritha-j · 2020-06-16T10:40:48Z

No description provided.

common/include/pcl/point_cloud.h

test/features/test_ii_normals.cpp

io/include/pcl/io/impl/pcd_io.hpp

features/include/pcl/features/impl/organized_edge_detection.hpp

features/include/pcl/features/impl/moment_of_inertia_estimation.hpp

common/src/gaussian.cpp

common/include/pcl/types.h

kunaltyagi · 2020-06-18T09:45:45Z

common/include/pcl/point_cloud.h

@@ -227,6 +227,7 @@ namespace pcl
      {}

      //TODO: check if copy/move contructors/assignment operators are needed
+      //TODO: remove casting of the return value of size() to index_t


I don't know if this would be picked up by doxygen

I'll add it as a doxygen command.

SergioRAgostinho

Partial (11/47)

common/include/pcl/impl/pcl_base.hpp

common/include/pcl/common/impl/spring.hpp

common/include/pcl/point_cloud.h

features/include/pcl/features/impl/integral_image_normal.hpp

features/include/pcl/features/impl/moment_of_inertia_estimation.hpp

haritha-j · 2020-07-07T08:38:51Z

Should I rebase this with the master? I'm guessing there'll be some conflicts to address.

Also, looks like I've missed a few warnings still.

kunaltyagi · 2020-07-07T09:01:15Z

Should I rebase this with the master?

Please wait a bit. Sorry about the delay on my side. I have 2 big PRs in line, they just became a bit too big to handle quickly for me

common/include/pcl/common/impl/spring.hpp

apps/in_hand_scanner/src/icp.cpp

apps/in_hand_scanner/src/integration.cpp

apps/src/ni_agast.cpp

apps/src/ni_brisk.cpp

common/include/pcl/common/impl/spring.hpp

test/io/test_grabbers.cpp

tracking/include/pcl/tracking/impl/pyramidal_klt.hpp

tools/gp3_surface.cpp

apps/src/ni_agast.cpp

SergioRAgostinho · 2020-07-14T11:30:55Z

apps/src/ni_brisk.cpp

+          image_viewer_.markPoint(int(pt.x),
+                                  int(pt.y),


common/include/pcl/point_cloud.h

kunaltyagi

33/150

kunaltyagi · 2020-07-15T10:05:52Z

...rec_framework/include/pcl/apps/3d_rec_framework/feature_wrapper/local/fpfh_local_estimator.h

-    signatures->resize(fpfhs->points.size());
-    signatures->width = static_cast<int>(fpfhs->points.size());
+    signatures->resize(fpfhs->size());
+    signatures->width = static_cast<int>(fpfhs->size());


Needless cast

kunaltyagi · 2020-07-15T10:06:01Z

...rec_framework/include/pcl/apps/3d_rec_framework/feature_wrapper/local/shot_local_estimator.h

-    signatures->resize(shots->points.size());
-    signatures->width = static_cast<int>(shots->points.size());
+    signatures->resize(shots->size());
+    signatures->width = static_cast<int>(shots->size());


kunaltyagi · 2020-07-15T10:06:11Z

...framework/include/pcl/apps/3d_rec_framework/feature_wrapper/local/shot_local_estimator_omp.h

-    signatures->resize(shots->points.size());
-    signatures->width = static_cast<int>(shots->points.size());
+    signatures->resize(shots->size());
+    signatures->width = static_cast<int>(shots->size());


Loads of places

kunaltyagi · 2020-07-15T10:07:51Z

apps/in_hand_scanner/src/icp.cpp

@@ -243,7 +243,7 @@ pcl::ihs::ICP::findTransformation (const MeshConstPtr&              mesh_model,
      // Check the distance threshold
      if (squared_distance [0] < squared_distance_threshold)
      {
-        if ((std::size_t) index [0] >= cloud_model_selected->size ())
+        if (static_cast<index_t>(index [0]) >= cloud_model_selected->size ())


Instead of cast here, L206 should be changed

kunaltyagi · 2020-07-15T10:11:59Z

common/include/pcl/common/impl/centroid.hpp

@@ -749,11 +749,11 @@ demeanPointCloud (const pcl::PointCloud<PointT> &cloud_in,
                  const Eigen::Matrix<Scalar, 4, 1> &centroid,
                  Eigen::Matrix<Scalar, Eigen::Dynamic, Eigen::Dynamic> &cloud_out)
 {
-  std::size_t npts = cloud_in.size ();
+  auto npts = cloud_in.size ();


kunaltyagi

67/150

kunaltyagi · 2020-07-16T14:50:24Z

features/include/pcl/features/impl/usc.hpp

@@ -228,7 +228,7 @@ pcl::UniqueShapeContext<PointInT, PointOutT, PointRFT>::computeFeature (PointClo

  output.is_dense = true;

-  for (std::size_t point_index = 0; point_index < indices_->size (); ++point_index)
+  for (index_t point_index = 0; point_index < static_cast<index_t>(indices_->size ()); point_index++)


Please use ++counter for uniformity in the for loops

kunaltyagi · 2020-07-16T14:51:23Z

filters/include/pcl/filters/impl/sampling_surface_normal.hpp

-    accu [6] += cloud[i].x;
-    accu [7] += cloud[i].y;
-    accu [8] += cloud[i].z;
+    accu [0] += pt.x * pt.x;


Some Eigen here?

kunaltyagi · 2020-07-16T14:52:11Z

filters/include/pcl/filters/impl/normal_refinement.hpp

@@ -67,7 +67,7 @@ pcl::NormalRefinement<NormalT>::applyFilter (PointCloud &output)

  // Check that correspondences are OK
  const unsigned int size = k_indices_.size ();


candidate for auto?

stale · 2020-08-16T07:28:51Z

Marking this as stale due to 30 days of inactivity. Commenting or adding a new commit to the pull request will revert this.

larshg · 2020-11-02T21:26:10Z

Should we try to revive this one, @kunaltyagi and @haritha-j.

Are you gonna do more work @haritha-j or should one of us take over?

haritha-j · 2020-11-04T09:12:48Z

Should we try to revive this one, @kunaltyagi and @haritha-j.

Are you gonna do more work @haritha-j or should one of us take over?

Sure, I can resume, a bit bogged down this week but will start by addressing the open comments next week.

larshg · 2020-11-04T09:22:37Z

Great to hear 👍

stale · 2020-12-19T08:47:28Z

Marking this as stale due to 30 days of inactivity. Commenting or adding a new commit to the pull request will revert this.

haritha-j added module: common priority: gsoc Reason for prioritization labels Jun 16, 2020

kunaltyagi reviewed Jun 16, 2020

View reviewed changes

common/include/pcl/point_cloud.h Outdated Show resolved Hide resolved

kunaltyagi added changelog: ABI break Meta-information for changelog generation changelog: API break Meta-information for changelog generation and removed changelog: ABI break Meta-information for changelog generation labels Jun 16, 2020

kunaltyagi added this to the pcl-1.12.0 milestone Jun 16, 2020

kunaltyagi added the needs: code review Specify why not closed/merged yet label Jun 16, 2020

kunaltyagi reviewed Jun 18, 2020

View reviewed changes

haritha-j added 4 commits June 22, 2020 18:07

convert point_cloud to indices

b8bce7f

fix -Wsign-compare warnings

c8d26ff

missed modules

635d2e0

remove uindex_t

4afca89

haritha-j force-pushed the pointcloud branch from 4be96f2 to 4afca89 Compare June 22, 2020 12:41

fix merge issue

04367a7

kunaltyagi changed the title ~~[common] Modify index type for pointCloud~~ TODO: Modify index type for pointCloud Jun 22, 2020

kunaltyagi changed the title ~~TODO: Modify index type for pointCloud~~ TODO: <Modify index type for pointCloud> Jun 22, 2020

SergioRAgostinho reviewed Jun 22, 2020

View reviewed changes

kunaltyagi marked this pull request as draft June 22, 2020 20:17

kunaltyagi mentioned this pull request Jun 23, 2020

In preparation for index_t, the cast needs to be removed #4212

Open

SergioRAgostinho added needs: more work Specify why not closed/merged yet and removed needs: code review Specify why not closed/merged yet labels Jun 29, 2020

haritha-j and others added 4 commits July 2, 2020 15:40

temp

b83a267

WIP

63c1523

WIP after paired programming.

fb8634f

additional index_t changes

a30079f

haritha-j added 2 commits July 7, 2020 16:47

additional fixes

dc5ae0e

fix clang template default value error

e4cea05

SergioRAgostinho reviewed Jul 9, 2020

View reviewed changes

common/include/pcl/common/impl/spring.hpp Show resolved Hide resolved

SergioRAgostinho requested changes Jul 9, 2020

View reviewed changes

various fixes

a64d329

SergioRAgostinho reviewed Jul 15, 2020

View reviewed changes

additional fixes

942521e

kunaltyagi reviewed Jul 15, 2020

View reviewed changes

Address partial review

9ce57ae

kunaltyagi reviewed Jul 16, 2020

View reviewed changes

stale bot added the status: stale label Aug 16, 2020

stale bot removed the status: stale label Nov 2, 2020

stale bot added the status: stale label Dec 19, 2020

kunaltyagi modified the milestones: pcl-1.12.0, pcl-1.12.1 Jun 30, 2021

stale bot removed status: stale labels Jun 30, 2021

mvieth modified the milestones: pcl-1.12.1, pcl-1.13.0 Nov 19, 2021

mvieth modified the milestones: pcl-1.13.0, pcl-1.14.0 Oct 19, 2022

larshg removed this from the pcl-1.14.0 milestone Jan 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TODO: <Modify index type for pointCloud> #4198

TODO: <Modify index type for pointCloud> #4198

haritha-j commented Jun 16, 2020

kunaltyagi Jun 18, 2020

haritha-j Jun 18, 2020

SergioRAgostinho left a comment

haritha-j commented Jul 7, 2020 •

edited

Loading

kunaltyagi commented Jul 7, 2020

SergioRAgostinho Jul 14, 2020

kunaltyagi left a comment

kunaltyagi Jul 15, 2020

kunaltyagi Jul 15, 2020

kunaltyagi Jul 15, 2020

kunaltyagi Jul 15, 2020

kunaltyagi Jul 15, 2020

kunaltyagi left a comment

kunaltyagi Jul 16, 2020

kunaltyagi Jul 16, 2020

kunaltyagi Jul 16, 2020

stale bot commented Aug 16, 2020

larshg commented Nov 2, 2020

haritha-j commented Nov 4, 2020

larshg commented Nov 4, 2020

stale bot commented Dec 19, 2020

		@@ -67,7 +67,7 @@ pcl::NormalRefinement<NormalT>::applyFilter (PointCloud &output)

		// Check that correspondences are OK
		const unsigned int size = k_indices_.size ();

TODO: <Modify index type for pointCloud> #4198

Are you sure you want to change the base?

TODO: <Modify index type for pointCloud> #4198

Conversation

haritha-j commented Jun 16, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SergioRAgostinho left a comment

Choose a reason for hiding this comment

haritha-j commented Jul 7, 2020 • edited Loading

kunaltyagi commented Jul 7, 2020

Choose a reason for hiding this comment

kunaltyagi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kunaltyagi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stale bot commented Aug 16, 2020

larshg commented Nov 2, 2020

haritha-j commented Nov 4, 2020

larshg commented Nov 4, 2020

stale bot commented Dec 19, 2020

haritha-j commented Jul 7, 2020 •

edited

Loading