Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In preparation for index_t, the cast needs to be removed #4212

Open
kunaltyagi opened this issue Jun 23, 2020 · 0 comments
Open

In preparation for index_t, the cast needs to be removed #4212

kunaltyagi opened this issue Jun 23, 2020 · 0 comments
Labels
effort: medium Rough estimate of time needed to fix/implement/solve good first issue Skills/areas of expertise needed to tackle the issue kind: todo Type of issue needs: pr merge Specify why not closed/merged yet priority: gsoc Reason for prioritization

Comments

@kunaltyagi
Copy link
Member

In preparation for index_t, the cast either needs to be removed or it needs to be set explicitly to index_t. I vote for removal unless it's unsupported.

Originally posted by @SergioRAgostinho in https://github.com/_render_node/MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDQ0NDE1MTE1NQ==/comments/review_comment

Needs CI run on the PR resolving this issue post #4198 merge
@kunaltyagi kunaltyagi added effort: medium Rough estimate of time needed to fix/implement/solve good first issue Skills/areas of expertise needed to tackle the issue needs: pr merge Specify why not closed/merged yet kind: todo Type of issue priority: gsoc Reason for prioritization labels Jun 23, 2020
@kunaltyagi kunaltyagi mentioned this issue Jun 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: medium Rough estimate of time needed to fix/implement/solve good first issue Skills/areas of expertise needed to tackle the issue kind: todo Type of issue needs: pr merge Specify why not closed/merged yet priority: gsoc Reason for prioritization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kunaltyagi