Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile issue in OutofcoreOctreeBase::setLODFilter after switching from boost::shared_ptr to std::shared_ptr #4081

Conversation

SunBlack
Copy link
Contributor

Fixes #4033.

Short explanation: Since #3750 we are using std::shared_ptr instead of boost::shared_ptr and it seems automatic downcasting does not work there anymore.

…g from boost::shared_ptr to std::shared_ptr
@kunaltyagi kunaltyagi added this to the pcl-1.11.1 milestone May 11, 2020
@kunaltyagi kunaltyagi added changelog: fix Meta-information for changelog generation module: outofcore needs: code review Specify why not closed/merged yet labels May 11, 2020
@kunaltyagi
Copy link
Member

If we were using clang on the CI, we would have caught this, right?

@SunBlack
Copy link
Contributor Author

Possible, just tested it with Clang 10 - not sure if older Clang version also complains it. In general Clang is more restrict than GCC, so it would be great to have an Clang 10 build.

@kunaltyagi
Copy link
Member

Let's have a clang CI in that case.

What would be a good way to run the clang CI?

  • Before/After Ubuntu CI (since it's ubuntu, but more restrictive): increases CI build time, but saves 2 or 1 slot (depending on before/after)
  • After macOS CI (because it's a better clang): macOS CI finish the fastest. saves slot and time
  • With Ubuntu CI (a simple addition in the CI matrix): consumes 1 more slot and doesn't save time in case of compilation failure

@SunBlack
Copy link
Contributor Author

I would add it behind macOS, so you have one line with GCC (Ubuntu), one with Clang (macOS/Ubuntu), MSVC (Windows)

@SergioRAgostinho SergioRAgostinho merged commit 4a1511b into PointCloudLibrary:master May 12, 2020
@SunBlack SunBlack deleted the fix_OutofcoreOctreeBase_setLODFilter branch May 12, 2020 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: fix Meta-information for changelog generation module: outofcore needs: code review Specify why not closed/merged yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[compile error] test_outofcore doesn't compile
3 participants