Fix error due to multiple declarations of template member function specializations in Poisson4 #3972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunaltyagi
added
module: surface
changelog: fix
kunaltyagi
changed the title
|
Error: [ 49%] Linking CXX executable ../../bin/pcl_example_nurbs_viewer_surface
../../lib/libpcl_surface.so.1.10.1.99: undefined reference to `pcl::poisson::BSplineElements<1>::upSample(pcl::poisson::BSplineElements<1>&) const'
../../lib/libpcl_surface.so.1.10.1.99: undefined reference to `pcl::poisson::BSplineElements<2>::upSample(pcl::poisson::BSplineElements<2>&) const'
|
taketwo
reviewed
Apr 29, 2020
kunaltyagi
added
needs: testing
taketwo
approved these changes
Apr 30, 2020
|
Note: squash and merge |
SergioRAgostinho
approved these changes
Apr 30, 2020
| Polynomial< 0 > Polynomial< 0 >::BSplineComponent( int i ) | ||
| { | ||
| Polynomial p; | ||
| p.coefficients[0] = 1.; | ||
| return p; | ||
| } | ||
| template< int Degree > | ||
| template< int Degree > inline |
There was a problem hiding this comment.
Marking this inline is debatable for me. But since it's just gut feeling, I will accept the change.
SergioRAgostinho
removed
the
needs: code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2nd split from #3841.
Partial fix for #3839