Add pipeline for building PCL's environment docker image

[kunaltyagi]

Features:

• Runs on master and PR
• Only runs when the file is modified
• Runs everyweek to keep the image updated
• No image updates on PR

squash-worthy

[taketwo]

Do we really need a daily build (vs. weekly or bi-weekly)? Our CI job queue is often full, why stressing it more?

[kunaltyagi]

Do we really need a daily build

Nope. Just added to keep it up to date. Frequency doesn't matter.

[kunaltyagi]

Lots of trial and error

[taketwo]

Let's get a look consistent with our other pipelines:

0. When I setup a new pipeline on Azure, I'll call it Docker.Env (in line with Build.Ubuntu, Build.Windows).
1. Inside the pipeline, no need to repeat "env docker image" in the job title because it will be a part of the pipeline name.
2. No need to repeat tag in the step names, that's evident from the job name.

Edit: and for the YAML filename I'd prefer docker-env.yaml, again to match the naming of other pipelines.

[kunaltyagi]

How does this look?

[taketwo]

This looks almost perfect! It's just that "Env" is still duplicated:

[kunaltyagi]

So the env in the title is from title, and that can't go away. Shall I replace the other env with "Image" or "Tag" or make it empty? Are job titles allowed to be empty?

[taketwo]

How is it going?

[kunaltyagi]

I don't have access to my 'build' hardware, so didn't test.

[kunaltyagi]

Only built common, geometry and a few other (non-CUDA/GPU) modules. No issues in compilation for the 16.04+CUDA-9.2

Let me add a verify stage to the CI for CI based verification

EDIT: I did, and all ubuntu CI pass with flying colors (for reduced set of modules)

[kunaltyagi]

Do you think it makes sense to integrate all into 1 pipeline?

1. Build docker image conditionally (my addition, stage 1)
2. Use the image to compile (current pipeline), confirms docker image if it was updated
3. Push image if compile succeeded (my addition, last stage)

The only thing I don't know is if docker images are persistent over stages.

Also, how do I run a step after all steps, like a cleanup step (especially after failure)? This is to delete the docker image if compile or push fails (to prevent bad caching on the local machine)

[taketwo]

Do you think it makes sense to integrate all into 1 pipeline?

Maybe. Maybe not. I'd propose to start with having a separate docker pipeline. This will be an improvement already. If after some time we feel like this separation limits us, then we can consider your proposal.

[kunaltyagi]

In that case, I'll consider this ready for review. PTAL

[taketwo]

🚀

[kunaltyagi]

@taketwo it needs a connection with the name (and passwd) on Azure in order to run correctly

[SergioRAgostinho]

@taketwo it needs a connection with the name (and passwd) on Azure in order to run correctly

Feel free to merge this at your own convenience since I'm unsure if this is ok to merge given your last comment.

[taketwo]

I'm also unsure, is there an action item for me?

[kunaltyagi]

Thanks to Sergio, who also has DockerHub access: No 😄

The pipeline is live: https://dev.azure.com/PointCloudLibrary/pcl/_build?definitionId=11&_a=summary

[taketwo]

Awesome. Should we also setup DockerHub access for you?

[kunaltyagi]

Already done courtesy of Sergio