Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sign-compare warnings issued by AppleClang #3777

Merged
merged 5 commits into from
Mar 23, 2020
Merged

Fix sign-compare warnings issued by AppleClang #3777

merged 5 commits into from
Mar 23, 2020

Conversation

kunaltyagi
Copy link
Member

No description provided.

@kunaltyagi kunaltyagi added needs: more work Specify why not closed/merged yet platform: macos changelog: fix Meta-information for changelog generation labels Mar 23, 2020
@kunaltyagi kunaltyagi changed the title Fix warnings on MacOS Catalina Fix sign-compare warnings issued by AppleClang Mar 23, 2020
@kunaltyagi kunaltyagi added needs: code review Specify why not closed/merged yet and removed needs: more work Specify why not closed/merged yet labels Mar 23, 2020
@kunaltyagi kunaltyagi marked this pull request as ready for review March 23, 2020 08:03
SergioRAgostinho
SergioRAgostinho requested changes Mar 23, 2020
View reviewed changes
Copy link
Member

@SergioRAgostinho SergioRAgostinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ci is running red with legitimate reasons.

@kunaltyagi
Copy link
Member Author

CI is green (except 19.10)

@SergioRAgostinho SergioRAgostinho added needs: author reply Specify why not closed/merged yet and removed needs: code review Specify why not closed/merged yet labels Mar 23, 2020
@kunaltyagi
Copy link
Member Author

Squash the last 3 commits?

@kunaltyagi kunaltyagi added needs: feedback Specify why not closed/merged yet and removed needs: author reply Specify why not closed/merged yet labels Mar 23, 2020
taketwo
taketwo approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@taketwo taketwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be fine with squash-all.

@SergioRAgostinho SergioRAgostinho removed the needs: feedback Specify why not closed/merged yet label Mar 23, 2020
@kunaltyagi kunaltyagi merged commit 237bc24 into PointCloudLibrary:master Mar 23, 2020
@kunaltyagi kunaltyagi deleted the catalina-warnings branch March 23, 2020 19:33
@kunaltyagi kunaltyagi mentioned this pull request Mar 23, 2020
Closed
22 tasks
shrijitsingh99 pushed a commit to shrijitsingh99/pcl that referenced this pull request Mar 24, 2020
@kunaltyagi @shrijitsingh99
Fix sign-compare warnings issued by AppleClang (PointCloudLibrary#3777)
19926a5 
* First bunch of -Wsign-compare

* Second bunch of -Wsign-compare

* Using Eigen::Matrix::Index for iteration
@kunaltyagi kunaltyagi mentioned this pull request Apr 23, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioRAgostinho SergioRAgostinho SergioRAgostinho approved these changes

@taketwo taketwo taketwo approved these changes

Assignees
No one assigned
Labels
changelog: fix Meta-information for changelog generation platform: macos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kunaltyagi @taketwo @SergioRAgostinho