Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in binary header generation for PCD files #3522

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Fix a bug in binary header generation for PCD files #3522

merged 1 commit into from
Jan 9, 2020

Conversation

chronofei
Copy link
Contributor

I think it is "i-1" rather than "i". because it is " cur_field.offset - prev_field.offset + sizeof (prev_field)".

Copy link
Member

@taketwo taketwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed looks like a bug, thanks.

@taketwo taketwo added kind: bug Type of issue module: io labels Jan 3, 2020
@kunaltyagi kunaltyagi merged commit 8bdd6c5 into PointCloudLibrary:master Jan 9, 2020
@taketwo taketwo changed the title Update pcd_io.cpp Fix a bug in binary header generation for PCD files Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants