Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link-type keywords in linked libraries in "PCLConfig.cmake" with CMake >= 3.11 #3341

Merged
merged 2 commits into from
Sep 14, 2019
Merged

Fix link-type keywords in linked libraries in "PCLConfig.cmake" with CMake >= 3.11 #3341

merged 2 commits into from
Sep 14, 2019

Conversation

traversaro
Copy link
Contributor

taketwo
taketwo approved these changes Sep 13, 2019
View reviewed changes
Copy link
Member

@taketwo taketwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing a fix.

Just to make it explicit, this fixes things only for CMake >= 3.11. Older versions are still prone to this issue. However, since vcpkg is using a fresh CMake, this indeed can be counted as a proper fix for #2989. Right?

PCLConfig.cmake.in Outdated
@@ -619,7 +619,7 @@ foreach(component ${PCL_TO_FIND_COMPONENTS})
INTERFACE_INCLUDE_DIRECTORIES "${PCL_${COMPONENT}_INCLUDE_DIRS}"
INTERFACE_LINK_LIBRARIES "${PCL_${COMPONENT}_LINK_LIBRARIES}"
)
else()
else(CMAKE_VERSION VERSION_LESS 3.11)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be elseif?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks for noticing and sorry for the noise, fixed in 0801d26, let me know if the rest of the PR seems ok so I can rebase it in the parent commit.

taketwo
taketwo requested changes Sep 13, 2019
View reviewed changes
Copy link
Member

@taketwo taketwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, wrong button. Please see my inline comment.

@taketwo taketwo added the needs: author reply Specify why not closed/merged yet label Sep 13, 2019
@traversaro traversaro changed the title Fix problem with link-type keywords in linked libraries in PCLConfig.cmake Fix problem with link-type keywords in linked libraries in PCLConfig.cmake with CMake >= 3.11 Sep 14, 2019
@traversaro
Copy link
Contributor Author

Just to make it explicit, this fixes things only for CMake >= 3.11. Older versions are still prone to this issue. However, since vcpkg is using a fresh CMake, this indeed can be counted as a proper fix for #2989. Right?

Yes, exactly, I update the PR title. Beside vcpkg, for most (even if not all) Windows uses using a recent CMake is fairly straightforward, so it make sense to not worry too much about compatibility with older CMake versions, at least from my point of view.

@taketwo taketwo removed the needs: author reply Specify why not closed/merged yet label Sep 14, 2019
taketwo
taketwo approved these changes Sep 14, 2019
View reviewed changes
Copy link
Member

@taketwo taketwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. No need to do anything else, I will squash while merging.

@taketwo taketwo changed the title Fix problem with link-type keywords in linked libraries in PCLConfig.cmake with CMake >= 3.11 Fix problem with link-type keywords in linked libraries in PCLC… Sep 14, 2019
@taketwo taketwo merged commit 2e4cc61 into PointCloudLibrary:master Sep 14, 2019
@taketwo taketwo changed the title Fix problem with link-type keywords in linked libraries in PCLC… Open Fix problem with link-type keywords in linked libraries in PCLConfig.cmake with CMake >= 3.11 Sep 14, 2019
@taketwo taketwo changed the title Open Fix problem with link-type keywords in linked libraries in PCLConfig.cmake with CMake >= 3.11 Fix link-type keywords in linked libraries in PCLConfig.cmake with CMake >= 3.11 Jan 14, 2020
@taketwo taketwo mentioned this pull request Jan 16, 2020
Closed
@taketwo taketwo changed the title Fix link-type keywords in linked libraries in PCLConfig.cmake with CMake >= 3.11 Fix link-type keywords in linked libraries in "PCLConfig.cmake" with CMake >= 3.11 Jan 18, 2020
@jslee02 jslee02 mentioned this pull request May 29, 2022
Merged
7 tasks
@nkhedekar nkhedekar mentioned this pull request Apr 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taketwo taketwo taketwo approved these changes

Assignees
No one assigned
Labels
module: cmake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cmake error when finding features component with windows 10 (vcpkg)
2 participants
@traversaro @taketwo