Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix finding OSG on Windows #1666

Merged
merged 3 commits into from
May 29, 2022
Merged

Fix finding OSG on Windows #1666

merged 3 commits into from
May 29, 2022

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented May 29, 2022


Before creating a pull request

  • Document new methods and classes
  • Format new code files using ClangFormat by running make format
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve all the compile warnings

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change
  • Add Python bindings for new methods and classes

@jslee02 jslee02 added this to the DART 6.13.0 milestone May 29, 2022
@codecov
Copy link

codecov bot commented May 29, 2022

Codecov Report

Merging #1666 (7c7fc02) into main (a240aac) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1666   +/-   ##
=======================================
  Coverage   59.09%   59.09%           
=======================================
  Files         499      499           
  Lines       40950    40950           
=======================================
  Hits        24200    24200           
  Misses      16750    16750           
Impacted Files Coverage Δ
dart/constraint/ConstraintSolver.cpp 70.58% <ø> (ø)
python/dartpy/gui/osg/GUIEventHandler.cpp 96.41% <ø> (ø)

@jslee02 jslee02 force-pushed the win_find_osg branch 3 times, most recently from ed09713 to ac11ab4 Compare May 29, 2022 08:08
@jslee02 jslee02 marked this pull request as draft May 29, 2022 08:16
@jslee02 jslee02 force-pushed the win_find_osg branch 2 times, most recently from 712368c to 3a7874d Compare May 29, 2022 08:52
@jslee02 jslee02 force-pushed the win_find_osg branch 2 times, most recently from 04723dd to cb4b71b Compare May 29, 2022 16:07
@jslee02 jslee02 marked this pull request as ready for review May 29, 2022 19:18
@jslee02 jslee02 merged commit d28c286 into main May 29, 2022
@jslee02 jslee02 deleted the win_find_osg branch May 29, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant