Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EIGEN_ALIGN16 positionining for point type XYZHSV #3237

Merged
merged 4 commits into from
Jul 18, 2019

Conversation

dooxe
Copy link
Contributor

@dooxe dooxe commented Jul 16, 2019

For point type XYZHSV structure, the EIGEN_ALIGN16 was positioned at the wrong place, leading to a compilation error.

Copy link
Member

@SergioRAgostinho SergioRAgostinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this triggers a compilation error in your dev environment but not in the 3 separate platforms we have on the CI server. 😕

Note to maintainers: Don't forget to squash.

@dooxe
Copy link
Contributor Author

dooxe commented Jul 17, 2019

Yes, I understand you disapointment. The placement of alignas modifier seems to be before the struct according to this doc:
https://en.cppreference.com/w/cpp/language/alignas
(I also found other examples of this syntax on MSDN doc and other pages).

From what I saw in PCL source code, some structures were corrected, some not.
Also, there is the same error in:

They are not in this pull request because I saw them after reporting this ... :/

@SergioRAgostinho
Copy link
Member

You can add them here as well. Push the extra commits to your branch.

Changed the position of EIGEN_ALIGN16 modifier.
Changed the position of modifier `EIGEN_ALIGN16` for the structure `ISMPeak`.
@taketwo taketwo merged commit c4d0e4b into PointCloudLibrary:master Jul 18, 2019
@taketwo taketwo changed the title Corrected EIGEN_ALIGN16 positionining for point type XYZHSV Fix EIGEN_ALIGN16 positionining for point type XYZHSV Jan 18, 2020
@AustinSanders AustinSanders mentioned this pull request Sep 30, 2021
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants