Skip to content

Fix ICP tutorial - #2244

Merged
taketwo merged 2 commits into
PointCloudLibrary:masterfrom
mpressig:fix-ICP-web-tuto
Mar 5, 2018
Merged

Fix ICP tutorial#2244
taketwo merged 2 commits into
PointCloudLibrary:masterfrom
mpressig:fix-ICP-web-tuto

Conversation

@mpressig

@mpressig mpressig commented Mar 5, 2018

Copy link
Copy Markdown
Contributor

Replace in the proposed basic ICP web tuto the call to the function setInputCloud (deprecated) by setInputSource. ICP will fail with setInputCloud, and will succeed with setInputSource

Replace in the proposed basic ICP web tuto the call to the function setInputCloud (deprecated) by setInputSource. ICP will fail with setInputCloud, and will succedd with setInputSource
@taketwo

taketwo commented Mar 5, 2018

Copy link
Copy Markdown
Member

Would you mind to update line 65 in the running text?

This creates an instance of an IterativeClosestPoint and gives it some useful information. "icp.setInputCloud(cloud_in);" sets cloud_in as the PointCloud to begin from and "icp.setInputTarget(cloud_out);" sets cloud_out as the PointCloud which we want cloud_in to look like.

Replace in rst file setInputCLoud by setInputSource for ICP web tuto
@mpressig

mpressig commented Mar 5, 2018

Copy link
Copy Markdown
Contributor Author

Ok, done

@taketwo
taketwo merged commit 26123cf into PointCloudLibrary:master Mar 5, 2018
@taketwo

taketwo commented Mar 5, 2018

Copy link
Copy Markdown
Member

Thanks

@mpressig
mpressig deleted the fix-ICP-web-tuto branch March 5, 2018 17:37
@taketwo taketwo changed the title fix icp web tuto Fix ICP tutorial Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants