Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ICP tutorial #2244

Merged
merged 2 commits into from
Mar 5, 2018
Merged

Conversation

mpressig
Copy link
Contributor

@mpressig mpressig commented Mar 5, 2018

Replace in the proposed basic ICP web tuto the call to the function setInputCloud (deprecated) by setInputSource. ICP will fail with setInputCloud, and will succeed with setInputSource

Replace in the proposed basic ICP web tuto the call to the function setInputCloud (deprecated) by setInputSource. ICP will fail with setInputCloud, and will succedd with setInputSource
@taketwo
Copy link
Member

taketwo commented Mar 5, 2018

Would you mind to update line 65 in the running text?

This creates an instance of an IterativeClosestPoint and gives it some useful information. "icp.setInputCloud(cloud_in);" sets cloud_in as the PointCloud to begin from and "icp.setInputTarget(cloud_out);" sets cloud_out as the PointCloud which we want cloud_in to look like.

Replace in rst file setInputCLoud by setInputSource for ICP web tuto
@mpressig
Copy link
Contributor Author

mpressig commented Mar 5, 2018

Ok, done

@taketwo taketwo merged commit 26123cf into PointCloudLibrary:master Mar 5, 2018
@taketwo
Copy link
Member

taketwo commented Mar 5, 2018

Thanks

@mpressig mpressig deleted the fix-ICP-web-tuto branch March 5, 2018 17:37
@taketwo taketwo changed the title fix icp web tuto Fix ICP tutorial Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants