Prevent search for disabled optional dependencies in targets. #2229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taketwo
reviewed
Feb 25, 2018
cmake/pcl_pclconfig.cmake
Outdated
| string(REGEX REPLACE "-(.*)" "" _condition ${_tmp}) #libusb-1.0 case | ||
| if(${${_condition}}) | ||
| set(PCLCONFIG_OPTIONAL_DEPENDENCIES "${PCLCONFIG_OPTIONAL_DEPENDENCIES}${_opt_dep} ") | ||
| endif(${${_condition}}) |
There was a problem hiding this comment.
It is not necessary to repeat condition expression in the endif since CMake 2.8.
cmake/pcl_pclconfig.cmake
Outdated
| set(PCLCONFIG_OPTIONAL_DEPENDENCIES "${PCLCONFIG_OPTIONAL_DEPENDENCIES}${_opt_dep} ") | ||
| string(TOUPPER "WITH_${_opt_dep}" _tmp) | ||
| string(REGEX REPLACE "-(.*)" "" _condition ${_tmp}) #libusb-1.0 case | ||
| if(${${_condition}}) |
There was a problem hiding this comment.
It is enough to supply variable name to if. Thus in this case
if(${_condition})
SergioRAgostinho
force-pushed
the
targets-opt-deps
branch
from
f42e50f
to
0c84328
Compare
|
I assume you tried to build/install/find_package after this change? |
|
Yep. I hit the bug on a fresh machine installation. I didn't have Qhull installed and cmake was throwing some problematic warnings/errors regarding Qhull not being found. |
|
Great. Small patch, but extremely useful 💯 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers the first issue mentioned in #1547.