Remove unreachable code in DefaultConvergenceCriteria - #1967
Merged
Conversation
jolesinski
suggested changes
Aug 19, 2017
| @@ -59,7 +59,6 @@ pcl::registration::DefaultConvergenceCriteria<Scalar>::hasConverged () | |||
| convergence_state_ = CONVERGENCE_CRITERIA_ITERATIONS; | |||
| return (true); | |||
| } | |||
Contributor
There was a problem hiding this comment.
For readability reasons, it would be good to also remove the wrapping else {}. See https://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html
Contributor
Author
|
@jolesinski updated as requested! |
UnaNancyOwen
pushed a commit
to UnaNancyOwen/pcl
that referenced
this pull request
Nov 24, 2017
Remove unreachable code in registration::DefaultConvergenceCriteria
taketwo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
which causes compilation warnings in Visual Studio