Add a MetaICP class #1426
Merged
Add a MetaICP class #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not limited to ICP, any registration algorithm will work, right? |
|
Yes. I was mirroring the IncrementalICP class (which also is not limited to
ICP), so I called it MetaICP. This is also the term for this method in
my working group.
|
|
I would propose to rename both classes to *Registration. |
|
+1 for renaming to *Registration. |
| bool | ||
| registerCloud (const PointCloudConstPtr& cloud, const Matrix4& delta_estimate = Matrix4::Identity ()); | ||
|
|
||
| /** \brief Get estimated transform */ |
There was a problem hiding this comment.
... of the last registered cloud?
This is quite similar in spirit to IncrementalICP, but matches new clouds to all previously registered clouds instead of only the last one. This is computationally more expensive, but provides a more robust matching when successive clouds do not alway cover nearby parts of the environment. As this (just as IncrementalICP) is a standard method to apply ICP in practice, I expected to find this functionality in PCL. As it wasn't there yet, I wrote this class.
|
I renamed the class to MetaRegistration and adjusted the interfaces as proposed.
As this request is not about IncrementalICP, I will not add changes for that here.
You're welcome to add a patch for this class yourself.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quite similar in spirit to IncrementalICP, but matches new clouds to
all previously registered clouds instead of only the last one. This is
computationally more expensive, but provides a more robust matching when
successive clouds do not alway cover nearby parts of the environment.
As this (just as IncrementalICP) is a standard method to apply ICP in
practice, I expected to find this functionality in PCL. As it wasn't there
yet, I wrote this class.