Batch block updates #1313
Merged
Batch block updates #1313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
w/o this change filling area selected on image below with stone takes >1min (didn't wait for it to finish, it may even crash)
with change, it takes few seconds. Cubyz.2025-04-17.16-19-07.mp4 |
IntegratedQuantum
requested changes
Apr 23, 2025
IntegratedQuantum
requested changes
Apr 24, 2025
2 tasks
Argmaster
commented
Apr 24, 2025
Argmaster
commented
Apr 24, 2025
IntegratedQuantum
requested changes
Apr 24, 2025
Collaborator
Author
|
Alright, depending on your opinion on reversing mesh ownership logic for |
Collaborator
Author
|
Resolved conflicts with latest master. |
IntegratedQuantum
requested changes
Apr 28, 2025
Collaborator
Author
|
Alright, changed mostly as requested, ofc I had to talk back 😝 |
Closed
IntegratedQuantum
requested changes
Apr 29, 2025
Argmaster
commented
Apr 29, 2025
Collaborator
Author
|
Alr getting rid of that formatting change was harder than I though xD |
IntegratedQuantum
approved these changes
May 1, 2025
Argmaster
added a commit
to Argmaster/Cubyz
that referenced
this pull request
May 21, 2025
* Batch block updates * Apply review change requests * Allow blockUpdate to carry multiple block updates in single message * Read until there is nothing left * Use mesh_storage.BlockUpdate * Break instead of boolean * Restore client side neighbor updates * Move side check in blockUpdate out of the loop * Update src/utils.zig * Fix minor issues * Reverse ownership logic + change contains into liesInChunk * Update liesInChunk * No name for upadeBlock param * Apply review change requests * Fix formatting * Restore onBreakClient where it should be * Update src/renderer/chunk_meshing.zig * Update src/renderer/chunk_meshing.zig * Converge formatting with master * fix formatting (ziglang/zig-spec#38 is so stupid) --------- Co-authored-by: IntegratedQuantum <jahe788@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I completely removed neighbor updates on client side, now server has to send block updates for changed blocks and any neighbors that got affected. This is also a step towards fixing #1217, It would require adding
updateNeighborsparameter tocmpxchgBlockor some other way to signalize that neighbors should remain unchanged. Depending on significance of network overhead maybe it would be good to allowupdateBlockprotocol to carry multiple blocks at once.Resolves: #610
Related to: #1309
Related to: #1214