Skip to content

Conversation

@Lilylicious
Copy link
Contributor

Fixes #669

Description of the problem being solved:

All minion skills implied a recent use of a minion skill if they were set as primary. This adds a flag to permanent minions and excludes them from the implication. You can still use the config checkbox to enable these interactions on non-permanent minions.

Steps taken to verify a working solution:

  • Allocated Enduring Bond, equipped Summon Holy Relic (permanent) and Summon Raging Spirits
  • Deallocating Enduring Bond without the config checked does not affect Summon Holy Relic DPS but does affect Summon Raging Spirits DPS
  • Selecting the config checkbox for recent minion use changes the DPS of Summon Holy Relic but not Summon Raging Spirits when Enduring Bond is allocated

Link to a build that showcases this PR:

https://pobb.in/89pQNZf6IFx1

@QuickStick123 QuickStick123 added the enhancement New feature, calculation, or mod label Aug 11, 2023
@LocalIdentity LocalIdentity merged commit 4e9b055 into PathOfBuildingCommunity:dev Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Have you used a Minion Skill Recently?" shouldn't be enabled by default if your main skill is a minion skill

3 participants