Allow Trade to weight by multiple stats #5507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regisle
force-pushed
the
AllowForMultipleStats
branch
from
2fd63b9 to
dfac0b8
Compare
Regisle
force-pushed
the
AllowForMultipleStats
branch
from
a7ea526 to
2c7e263
Compare
1 task
Dullson
pushed a commit
to Dullson/PathOfBuilding
that referenced
this pull request
Dec 6, 2023
* Initial Support for sorting by different stat instead of DPS * rename calcSortIndex and apply default value checks * initial support for multiple stats * fix merge issues * fix merge issues * fix stat weight defualts and reuse old values when opening change popup * fix whitepsace * move to using a listController * update default item sort order and fix full dps issue * fix incorrect variable * fix merge issue * fix merge issues * fix merge issues * update formatting * fix spelling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow user to change what stat(s) trade "find best" weights by, default is still fullDPS but also some EHP, and also allows for dots, defences like max hit, or other misc stats like movement speed
supersedes #5376
Has a few minor formatting issues but should be fine to merge and fix later