Add Megalomaniac search to Trader #5714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plus some generic improvements, including more extensible control placement, some small bug fixes and a decent bit of refactoring (i.e. renamed a lot of variables to make them more uniform)
# Conflicts: # src/Classes/TradeQuery.lua # src/Classes/TradeQueryGenerator.lua
# Conflicts: # src/Classes/TradeQuery.lua # src/Classes/TradeQueryRequests.lua
# Conflicts: # src/Classes/TradeQuery.lua # src/Classes/TradeQueryGenerator.lua # src/Classes/TradeStatWeightMultiplierListControl.lua
LocalIdentity
approved these changes
Apr 21, 2023
Dullson
pushed a commit
to Dullson/PathOfBuilding
that referenced
this pull request
Dec 6, 2023
* Initial Support for sorting by different stat instead of DPS * rename calcSortIndex and apply default value checks * initial support for multiple stats * fix merge issues * fix merge issues * fix stat weight defualts and reuse old values when opening change popup * fix whitepsace * move to using a listController * update default item sort order and fix full dps issue * fix incorrect variable * fix merge issue * fix merge issues * fix merge issues * update formatting * fix spelling * update item weight and sorting to use percentage change rather than abs * ratio modweights and dont divide by 0 * change function to local * change function to local * make function not local * fix function call * Add megalomaniac search to trade tool Plus some generic improvements, including more extensible control placement, some small bug fixes and a decent bit of refactoring (i.e. renamed a lot of variables to make them more uniform) --------- Co-authored-by: Regisle <Regisle.godform@gmail.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5485 .
Built on #5525 which in turn is built on #5507.
Description of the problem being solved:
It is very hard and cumbersome to make a search for a Megalomaniac, and then evaluating the results is mostly eye-balling.
Steps taken to verify a working solution:
After screenshots: