Skip to content

Conversation

@fialhoFabio
Copy link
Contributor

@fialhoFabio fialhoFabio commented Dec 5, 2022

Fixes #5131.

Description of the problem being solved:

Armour Cruncher was missing from the spectre list.

Steps taken to verify a working solution:

  • It wasn't on the list
  • Add to the Spectres.txt and generate code
  • It is on the list now
  • Numbers are correct, but the curse on hit effect is not getting applied

Link to a build that showcases this PR:

https://pastebin.com/EUxKfbDe

Before screenshot:

image

After screenshot:

image
image

@fialhoFabio
Copy link
Contributor Author

I don't know how to make him apply vulnerability on the calcs
idk if have something to do with this commented mod

image

@fialhoFabio
Copy link
Contributor Author

btw i saw the PR #5131, and thought it was a good first issue to try.

@QuickStick123
Copy link
Contributor

See SeawitchVulnerability as how you would go about implementing curses on spectres.
image
image
image

@fialhoFabio
Copy link
Contributor Author

I don't think that the Sea Witch is a comparison, she has a skill that apply vulnerability, but the armour crusher has a mod that apply it on hit, and i can't find a spectre that do the same thing.

image

@fialhoFabio
Copy link
Contributor Author

Well i kinda found something similar, like the blackguard mage that have spellBlockChance mod on him... idk

image

@QuickStick123
Copy link
Contributor

Yeah it might be new case there currently isn't anything like it in the codebase atm. So if you want to properly support it you could try to figure out minion trigger stuff which mightn't be supported ? not sure.
Here is the current curse on hit stuff.
image

If you want to be able to more easily ask people questions about how you might implement this stuff join the discord by asking one of the maintainers to invite you.

There is a Discord server for active development on the fork and members are happy to answer your questions there. If you are interested in joining, send a private message to any of Cinnabarit#1341, LocalIdentity#9871, Yamin#5575 and we'll send you an invitation.

@fialhoFabio fialhoFabio marked this pull request as ready for review December 6, 2022 13:25
@fialhoFabio
Copy link
Contributor Author

Idk if this is the correct way of increase the curse effect, but 30 * 1.04 = 31.2 and that is +2 gem lvl

@fialhoFabio
Copy link
Contributor Author

image

@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Dec 8, 2022
@LocalIdentity LocalIdentity changed the title 5131-armour-crusher-spectre Add Armour Cruncher Spectre Dec 8, 2022
@LocalIdentity LocalIdentity merged commit 6a72a5b into PathOfBuildingCommunity:dev Dec 8, 2022
@QuickStick123 QuickStick123 mentioned this pull request Dec 8, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants