Skip to content

Conversation

@michelrtm
Copy link
Contributor

Fixes #5127 .

Description of the problem being solved:

Armour Cruncher was missing from the Spectre list.

Steps taken to verify a working solution:

  • Checked that Armour Cruncher wasn't in the original list
  • Added an entry for Armour Cruncher into the Spectre list
  • Checked that the values are correct and values are calculated when adding Armour Cruncher to the list of spectres in the build

Link to a build that showcases this PR:

N/A

Before screenshot:

Raise Spectre 0
Armour Cruncher missing from list.

After screenshot:

Raise Spectre 1
Raise Spectre added to the Build.

Raise Spectre 2
Armour Cruncher now displays on the list and values are calculated.

Raise Spectre 3
When spectre is added the build calculations update accordingly.

@QuickStick123 QuickStick123 added the enhancement New feature, calculation, or mod label Oct 10, 2022
@LocalIdentity
Copy link
Contributor

This is not how we add additional spectres to PoB. We do not manually change the .lua files as they are auto-generated when we run export scripts on the game files. In order to add new spectres to PoB you need to edit the relevant .txt file then run the export scripts.
Have a look here at how the Pale Angel spectre was added https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/3639/files
If you are not in the PoB discord server, send me a message (LocalIdentity#9871) and I'll give you an invite

@LocalIdentity
Copy link
Contributor

Superseded by #5201

@michelrtm michelrtm deleted the 5127-add-armour-cruncher-to-spectre-list branch December 8, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Armour Cruncher

3 participants