Update Unique wording differences #4952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuickStick123
changed the title
QuickStick123
changed the title
2 tasks
This was referenced Aug 27, 2022
QuickStick123
force-pushed
the
update-wording-difference-post-launch
branch
from
486ac2d to
d3a645a
Compare
This was referenced Aug 30, 2022
QuickStick123
force-pushed
the
update-wording-difference-post-launch
branch
from
e5a8716 to
44c2656
Compare
QuickStick123
force-pushed
the
update-wording-difference-post-launch
branch
from
fea49e6 to
3cc18c5
Compare
ifnjeff
reviewed
Dec 5, 2022
2 tasks
Wires77
reviewed
Dec 9, 2022
| Share Endurance Charges with nearby party members | ||
| {variant:5}Your nearby party members' maximum Endurance Charges are equal to yours. | ||
| {variant:1,2,3,4}Share Endurance Charges with nearby party members | ||
| {variant:5}Your nearby party members maximum Endurance Charges is equal to yours |
There was a problem hiding this comment.
Grammar like this bothers me, but it matches in-game, so c'est la vie
Wires77
approved these changes
Dec 9, 2022
|
I have reviewed this myself at least 3 times so I am fairly confident it is fine. |
Wires77
changed the title
Wires77
changed the title
Same, honestly. There wasn't much new since I reviewed it 3 months ago |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4971 #5006
This includes the suggest/started changes completed in #2536
I updated all the items but have not added legacy variants for these as would need to add support.
There is a bug which is much more noticable with multibase/level requirement uniques where they don't update.
["^(%d+)"] = "BASE", was added to get # life on block working as it no longer has any + sign.
It is a very broad form which may cause issues.