Add basic support to show skill PvP scaling #4664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Aug 8, 2022
LocalIdentity
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a subset of #277 to allow people to check how much damage they do under PvP scaling conditions like the hall of grandmasters map, this has been reduced to the point where it has no effect on the rest of the program and touches as little as is needed to get it functional,
Proper support for Dots, Impale, Tvalues modifiers/overrides and PvP multipliers can be added later
as well as support for PvP damage taken
These are left out of this PR as the last one was deemed "too large" to merge
This is done by adding a button to toggle pvp scaling on, and if so it adds the PvP average hit and dps to the sidebar and calcs tab, along with a breakdown of how its calculated, it also adds options to override the Tvalue andor PvP damage multiplier