Added partial support for Hall of grandmasters pvp scaling #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still missing total dot, and need to add more flags for showing/hiding things on sidebar and from calcs tab
as well as cleaned up pvp calculations and fixed an issue with infinite Tvalue
added the missing flags as well as implemented checks so that pvp things are hidden when not toggeled
|
As this has been up for a while, there is a feature freeze soon and there are some bugs in the original that are fixed in the newer code, I decided to update my main branch and thus also the PR. The new update also supports PvP scaling on dots and impale, as well as displays it on minion stats on the side. The code has been cleaned up and moved around, and although there is more to review, all of the code only interacts with other PvP stuff and thus has no effect outside it |
|
This is very out of date with many merge conflicts and new issues, will likely redo this at some point and make a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of support for PvP scaling for Hall of Grandmasters unique map. The first PR is just implementing the pvp forumla with hits as well as displaying or hiding them based on the config option
it also supports Tvalue override and custom PvP multipliers but does not automatically set these