Skip to content

[Cherry-pick] The 4th part of new custom op #31282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 28, 2021
Merged

[Cherry-pick] The 4th part of new custom op #31282

merged 7 commits into from
Feb 28, 2021

Conversation

@chenwhql
Copy link
Contributor

@chenwhql chenwhql commented Feb 27, 2021 •
edited
Loading

PR types

Function optimization

PR changes

Others

Describe

[Cherry-pick] The 4th part of new custom op

  • modify win custom op deps
  • remove inner dtype
  • add Tensor.stream method
  • adjust header file name and include path
  • add PD_CHECK

zhwesky2010 and others added 4 commits February 27, 2021 08:17
@zhwesky2010 @chenwhql
modify custom op dependent from paddle_framework to paddle_custom_op (P…
b96f5f9 
…addlePaddle#31195)
@JiabinYang @chenwhql
[Custom Op] Remove unsupport dtypes (PaddlePaddle#31232)
ba514b5 
* remove remove_unsupport_dtype

* remove remove_unsupport_dtype

* remove test dtype

* add more include

* change dtype.h's enum as enum class to avoid conflict with inference lib

* make enum as enum class

* remove additional test

* merge develop

* polish code
@JiabinYang @chenwhql
[Custom OP] Support stream set on Custom Op (PaddlePaddle#31257)
7baaa2f
@Shixiaowei02 @chenwhql
[Custom OP] change the user header file format, test=develop (PaddleP…
ddb7bae 
…addle#31274)
@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zhwesky2010
zhwesky2010 previously approved these changes Feb 27, 2021
View reviewed changes
@zhwesky2010 @chenwhql
[Custom OP]add PD_THROW and PD_CHECK for User Error message (PaddlePa…
430dcfa 
…ddle#31253)

* [Custom OP]add PD_THROW and PD_CHECK for User error message

* PD_THROW and PD_CHECK, fix comment

* fix Windows error message

* fix Windows error message

* fix CI
zhwesky2010
zhwesky2010 previously approved these changes Feb 27, 2021
View reviewed changes
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Aurelius84
Aurelius84 previously approved these changes Feb 28, 2021
View reviewed changes
zhwesky2010
zhwesky2010 approved these changes Feb 28, 2021
View reviewed changes
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanxianghit lanxianghit merged commit 777d1a4 into PaddlePaddle:release/2.0 Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raindrops2sea raindrops2sea raindrops2sea approved these changes

@lanxianghit lanxianghit lanxianghit approved these changes

@zhwesky2010 zhwesky2010 zhwesky2010 approved these changes

@Aurelius84 Aurelius84 Aurelius84 left review comments

@Shixiaowei02 Shixiaowei02 Awaiting requested review from Shixiaowei02

@JiabinYang JiabinYang Awaiting requested review from JiabinYang

@phlrain phlrain Awaiting requested review from phlrain

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@chenwhql @Aurelius84 @raindrops2sea @lanxianghit @zhwesky2010 @JiabinYang @Shixiaowei02